Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/google: Added url map resource + tests & documentation #3722

Merged
merged 1 commit into from
Nov 2, 2015

Conversation

lwander
Copy link
Contributor

@lwander lwander commented Nov 2, 2015

No description provided.

return fmt.Errorf("Error, failed to insert Url Map %s: %s", name, err)
}

err = computeOperationWaitGlobal(config, op, "Insert Url Map");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

semicolon on the end of the line

@catsby
Copy link
Contributor

catsby commented Nov 2, 2015

Hey @lwander, go fmt ./... picked up a few things as well, can we run that on this PR? Thanks!

Manages a VM instance resource within GCE.
---

# google\_compute\_instance
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

title is wrong

@lwander
Copy link
Contributor Author

lwander commented Nov 2, 2015

@catsby, sure thing! I'll squash once Dave finishes looking over this PR.

@lwander lwander force-pushed the f-gcp-url-maps branch 2 times, most recently from 10e691e to 4e309ea Compare November 2, 2015 22:10
sparkprime added a commit that referenced this pull request Nov 2, 2015
provider/google: Added url map resource + tests & documentation
@sparkprime sparkprime merged commit 519756c into hashicorp:master Nov 2, 2015
@ghost
Copy link

ghost commented Apr 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants