-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provider/digitalocean: Making user_data force a new droplet #3740
Conversation
"foobar foobar"), | ||
), | ||
}, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want to prove this was accomplished by a recreate and not an update, I think you'll need to have two different droplet
variables and ensure that their IDs are different.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@phinze I must admin that I am not quite sure how I would do that :)
Any pointers to places that do that already in the codebase?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries! I'll pull this in as is, tweak it, and highlight you on the commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks - this is certainly something that will be useful going forward as I introduce tests when I make changes :)
This sounds good to me! And it matches up with equivalent behavior from other providers. One proposed addition to the test and then this is good to go. 👍 |
provider/digitalocean: Making user_data force a new droplet
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Fixes #3734
user_data is only run on instance first boot, therefore, changing the user_data will have no effect unless the instance is recreated. This follows the same behaviour as an AWS Instance
There is no way in the Digital Ocean UI to change the user_data. So it requires an instance to be recreated
Added an acceptance test to prove that it destroys and then recreates: