Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/google: Fix instance group manager instance restart policy #3892

Merged
merged 1 commit into from
Dec 15, 2015

Conversation

lwander
Copy link
Contributor

@lwander lwander commented Nov 12, 2015

As pointed out in #3875, instance_group_manager does not restart instances on an instance_template change. Since some people might not want this behavior, I added a update_strategy field to allow instance_template changes to avoid restarting instances (see the options here). @jen20 @sparkprime @premist

@premist
Copy link
Contributor

premist commented Nov 13, 2015

I checked out this PR(lwander/terraform@7be9021) locally and I got the following error. Is there something I need to configure additionally?

~/Development/infrastructure master*
❯ terraform -v
Terraform v0.6.7-dev (7be90215bcf00b05d7b7d14ebcee60cc39bfeeee+CHANGES)


~/Development/infrastructure master*
❯ terraform plan
There are warnings and/or errors related to your configuration. Please
fix these before continuing.

Errors:

  * google_compute_instance_group_manager.xxxxx: : invalid or unknown key: update_strategy

@lwander
Copy link
Contributor Author

lwander commented Nov 13, 2015

Did you run make dev? Can you post your TF file? I can't seem to replicate that.

@lwander
Copy link
Contributor Author

lwander commented Dec 1, 2015

@premist have you had a chance to try again?

@lwander lwander added the waiting-response An issue/pull request is waiting for a response from the community label Dec 7, 2015
@premist
Copy link
Contributor

premist commented Dec 15, 2015

Hi @lwander, previously I did run make dev, copied binaries to my PATH and I got the error above.

I tried again just now after resetting my go environment, and it works as intended (attaching terraform plan results below). Sorry for the confusion!

~ google_compute_instance_group_manager.xxx
    update_strategy: "" => "RESTART"

lwander added a commit that referenced this pull request Dec 15, 2015
provider/google: Fix instance group manager instance restart policy
@lwander lwander merged commit 41cd85c into hashicorp:master Dec 15, 2015
@lwander lwander deleted the b-gcp-instance-group-restart branch January 13, 2016 22:19
omeid pushed a commit to omeid/terraform that referenced this pull request Mar 30, 2018
resource/aws_security_group: Fix Missing Id Error
omeid pushed a commit to omeid/terraform that referenced this pull request Mar 30, 2018
@ghost
Copy link

ghost commented Apr 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement provider/google-cloud waiting-response An issue/pull request is waiting for a response from the community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants