provider/aws: Prevent crashing when deleting ecs_service which is gone #3914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeksimko
force-pushed
the
b-aws-ecs-service-gone
branch
from
aeeca5b
to
0822776
Compare
|
Looks good @radeksimko 👍 |
radeksimko
added a commit
that referenced
this pull request
Nov 16, 2015
provider/aws: Prevent crashing when deleting ecs_service which is gone
| @@ -156,6 +156,8 @@ func resourceAwsEcsServiceRead(d *schema.ResourceData, meta interface{}) error { | |||
| } | |||
|
|
|||
| if len(out.Services) < 1 { | |||
| log.Printf("[DEBUG] Removing ECS service %q because it's gone", service.ServiceArn) | |||
There was a problem hiding this comment.
service here is undefined 😵
1 errors occurred:
--> darwin/amd64 error: exit status 2
Stderr: # github.com/hashicorp/terraform/builtin/providers/aws
builtin/providers/aws/resource_aws_ecs_service.go:159: undefined: service
There was a problem hiding this comment.
doh... sorry about that!
There was a problem hiding this comment.
I wonder why Travis didn't pick this up btw.
There was a problem hiding this comment.
I wonder why Travis didn't pick this up btw.
I was wondering the same thing. Very strange 😕 Oh well, it's fixed, thanks for the follow up PR 😄
omeid
pushed a commit
to omeid/terraform
that referenced
this pull request
Mar 30, 2018
…nal-sidebar-sort docs: Sort WAF(regional) links in sidebar
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3868 and also addresses #3829 (comment)