Enable specifying aws s3 redirect protocol #4098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @csabapalfi – I'm terribly sorry for the silence here. Yes, this is a thing we'd love to support! Right now it looks like the this PR needs a rebase and acceptance tests, do you think you can handle that? If not I totally understand, especially considering the long silence here. Let us know! |
catsby
added
the
waiting-response
|
@catsby Sure. Looking into this now:
|
Signed-off-by: Csaba Palfi <[email protected]>
|
@catsby I think I'm done, please review and merge. |
catsby
removed
the
waiting-response
|
checks out, thanks! |
catsby
added a commit
that referenced
this pull request
Jan 22, 2016
Enable specifying aws s3 redirect protocol
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
S3 website redirect configurations allows specifying a protocol for redirects (http or https).
This PR adds support for that using the same
redirect_all_requests_tofield by specifying a protocol there e.g:redirect_all_requests_to = https://hashicorp.comwill result in{ HostName: hashicorp.com, Protocol: https }being sent to AWS. When no protocol is specified behaviour remains the same as before.Still need to update docs and tests. Please let me know if this is a feature you'd want to merge.