vSphere: Support mounting ISO images to virtual cdrom drives. #4243

kristinn · 2015-12-09T23:49:48Z

It can come in handy to be able to mount ISOs programmatically.
For instance if you're developing a custom appliance (that automatically installs itself on the hard drive volume)
that you want to automatically test on every successful build (given the ISO is uploaded to the vmware datastore).

There are probably lots of other reasons for using this functionality.

kristinn · 2015-12-09T23:50:12Z

Please verify the new acceptance test (the one I just created) works for you as well. I have verified it works on my vmware setup.

tkak · 2015-12-14T23:15:16Z

I'll try to check the acceptance test. 👍

kristinn · 2015-12-15T10:25:28Z

Ok great! 😄

tkak · 2015-12-18T11:11:10Z

@kristinn I tried to check the acceptance test. But, I got the following error messages.

TF_ACC=1 go test ./builtin/providers/vsphere -v -run=VirtualMachine_createWithCdrom -timeout 90m
=== RUN   TestAccVSphereVirtualMachine_createWithCdrom
--- FAIL: TestAccVSphereVirtualMachine_createWithCdrom (113.61s)
    testing.go:144: Step 0 error: Error applying: 1 error(s) occurred:

        * vsphere_virtual_machine.with_cdrom: Invalid configuration for device '0'.
FAIL
exit status 1
FAIL    github.com/hashicorp/terraform/builtin/providers/vsphere    113.639s
Makefile:37: recipe for target 'testacc' failed
make: *** [testacc] Error 1

This is a hardware information of the new VM.

☁  ~  govc device.ls -vm.ipath=/xxx/vm/terraform-test-with-cdrom                                                                                                         [~]
ide-200       VirtualIDEController       IDE 0
ide-201       VirtualIDEController       IDE 1
ps2-300       VirtualPS2Controller       PS2 controller 0
pci-100       VirtualPCIController       PCI controller 0
sio-400       VirtualSIOController       SIO controller 0
keyboard-600  VirtualKeyboard            Keyboard
pointing-700  VirtualPointingDevice      Pointing device; Device
video-500     VirtualMachineVideoCard    Video card
vmci-12000    VirtualMachineVMCIDevice   Device on the virtual machine PCI bus that provides support for the virtual machine communication interface
pvscsi-1000   ParaVirtualSCSIController  VMware paravirtual SCSI
cdrom-3002    VirtualCdrom               Remote device CD/DVD drive 1
disk-1000-0   VirtualDisk                31,457,280 KB
ethernet-0    VirtualVmxnet3             DVSwitch: ee c6 25 50 c0 e8 4f 08-c9 31 b4 f8 fb a3 3b 98
☁  ~

kristinn · 2015-12-18T13:37:33Z

@tkak Ok I see. I will take a look at this. Thank you for running the test.

kristinn · 2015-12-19T23:16:07Z

@tkak Did you export all the required environment variables?

cdromDatastore := os.Getenv("VSPHERE_CDROM_DATASTORE")
cdromPath := os.Getenv("VSPHERE_CDROM_PATH")

These ones are new ones that I introduced in my acceptance test.

The cdromDatastore needs to be the name of your datastore as it shows up in your vmware console. The cdromPath needs to be an absolute path to an ISO within the cdromDatastore.

I can't see the ISO being mounted in the information you provided about the virtual machine.

I was running the test and it works for me. The ISO you point to in the environment variables must exist in the datastore.

tkak · 2015-12-22T00:01:54Z

@kristinn Yes, I set the environment variables. But I got the error message.

Anyway, I resolved the issue by moving a location to call createCdroms(newVM, vm.cdroms) to before newVM.Customize(context.TODO(), customSpec). And the acceptance test works in our environment. So, could you fix that?

==> Checking that code complies with gofmt requirements...
go generate ./...
TF_ACC=1 go test ./builtin/providers/vsphere -v -run=VirtualMachine_createWithCdrom -timeout 90m
=== RUN   TestAccVSphereVirtualMachine_createWithCdrom
--- PASS: TestAccVSphereVirtualMachine_createWithCdrom (334.15s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/vsphere    334.188s

tkak · 2015-12-22T00:07:02Z

builtin/providers/vsphere/resource_vsphere_virtual_machine.go

@@ -1231,6 +1325,12 @@ func (vm *virtualMachine) deployVirtualMachine(c *govmomi.Client) error {
 			return err
 		}
 	}
+
+	// Create the cdroms if needed.
+	if err := createCdroms(newVM, vm.cdroms); err != nil {


Can you move this to L1310 (before the newVM.Customize(context.TODO(), customSpec))?

Ah, ok so that's the reason.

I will do that. Thanks a lot!

One question. Shouldn't it call createCdroms() from both createVirtualMachine() and from deployVirtualMachine()?

Isn't deployVirtualMachine() used for cloning but createVirtualMachine() when creating a brand new vm?

kristinn · 2015-12-22T10:17:40Z

Now I've updated the code so the cdrom creation is before the customization call. 😄

kristinn · 2015-12-22T10:21:57Z

I only moved the createCdroms() call in deployVirtualMachine(). I didn't move it in the createVirtualMachine() function since there is no customization call there. I did reply to your comment on the code where you ask me to move createCdroms() around. There you can see my explanation and a question.

tkak · 2016-01-07T00:42:44Z

@kristinn Thank you for your modification. 😄 I think it looks good. There isn't the error message in case of createVirtualMachine() as you say. Thanks!

kristinn · 2016-01-07T08:27:38Z

Awesome! 😄

kristinn · 2016-04-20T17:41:37Z

@chrislovecnm it's actually this one we should merge since it provides support for mounting isos from different datastores than the vm is hosted on.

chrislovecnm · 2016-04-20T18:19:11Z

@jen20 @phinze please merge ;)

kristinn · 2016-04-20T18:59:44Z

I will rebase this to fix the conflicts.

chrislovecnm · 2016-04-20T19:22:58Z

@kristinn thanks

It can come in handy to be able to mount ISOs programmatically. For instance if you're developing a custom appliance (that automatically installs itself on the hard drive volume) that you want to automatically test on every successful build (given the ISO is uploaded to the vmware datastore). There are probably lots of other reasons for using this functionality.

kristinn · 2016-04-20T19:59:26Z

website/source/docs/providers/vsphere/r/virtual_machine.html.markdown

@@ -71,6 +72,9 @@ The `windows_opt_config` block supports:
 * `domain_user` - (Optional) User that is a member of the specified domain.
 * `domain_user_password` - (Optional) Password for domain user, in plain text.

+<a id="disks"></a>
+## Disks
+


I decided to add this since it was missing (it's being linked to in line 48, but clicking that link wouldn't do much).

kristinn · 2016-04-20T20:00:59Z

I added information about this change to the website documentation (the markdown files).

This is squashed, I've executed the acceptance test and it seems to be ready for merge - after Travis has built it successfully.

kristinn · 2016-04-21T08:20:00Z

@chrislovecnm Just in case you didn't get a notification about my last comment. 😄

This can be merged now.

jen20 · 2016-04-21T22:50:04Z

LGTM! Thanks to all involved.

ghost · 2020-04-26T02:17:46Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

jen20 added enhancement provider/vsphere labels Dec 10, 2015

kristinn force-pushed the vsphere-cdrom-support branch from cab5149 to ee5a399 Compare December 19, 2015 23:14

tkak reviewed Dec 22, 2015
View reviewed changes

kristinn force-pushed the vsphere-cdrom-support branch 2 times, most recently from 201953e to 9fa7e5e Compare December 22, 2015 10:17

chrislovecnm mentioned this pull request Apr 15, 2016

Adding cdrom support #6147

Closed

kristinn force-pushed the vsphere-cdrom-support branch from 9fa7e5e to ef04fcb Compare April 20, 2016 19:32

kristinn force-pushed the vsphere-cdrom-support branch from ef04fcb to a67fa66 Compare April 20, 2016 19:58

kristinn reviewed Apr 20, 2016
View reviewed changes

ringods mentioned this pull request Apr 21, 2016

vSphere Provider: Mapping out the Next Steps #3624

Closed

jen20 merged commit 5b1b49e into hashicorp:master Apr 21, 2016

bobtfish mentioned this pull request May 5, 2016

Rebase from hashicorp/terraform Yelp/terraform#15

Merged

ghost locked and limited conversation to collaborators Apr 26, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

vSphere: Support mounting ISO images to virtual cdrom drives. #4243

vSphere: Support mounting ISO images to virtual cdrom drives. #4243

kristinn commented Dec 9, 2015

kristinn commented Dec 9, 2015

tkak commented Dec 14, 2015

kristinn commented Dec 15, 2015

tkak commented Dec 18, 2015

kristinn commented Dec 18, 2015

kristinn commented Dec 19, 2015

tkak commented Dec 22, 2015

tkak Dec 22, 2015

kristinn Dec 22, 2015

kristinn Dec 22, 2015

kristinn commented Dec 22, 2015

kristinn commented Dec 22, 2015

tkak commented Jan 7, 2016

kristinn commented Jan 7, 2016

kristinn commented Apr 20, 2016

chrislovecnm commented Apr 20, 2016

kristinn commented Apr 20, 2016

chrislovecnm commented Apr 20, 2016

kristinn Apr 20, 2016

kristinn commented Apr 20, 2016

kristinn commented Apr 21, 2016

jen20 commented Apr 21, 2016

ghost commented Apr 26, 2020

vSphere: Support mounting ISO images to virtual cdrom drives. #4243

vSphere: Support mounting ISO images to virtual cdrom drives. #4243

Conversation

kristinn commented Dec 9, 2015

kristinn commented Dec 9, 2015

tkak commented Dec 14, 2015

kristinn commented Dec 15, 2015

tkak commented Dec 18, 2015

kristinn commented Dec 18, 2015

kristinn commented Dec 19, 2015

tkak commented Dec 22, 2015

tkak Dec 22, 2015

Choose a reason for hiding this comment

kristinn Dec 22, 2015

Choose a reason for hiding this comment

kristinn Dec 22, 2015

Choose a reason for hiding this comment

kristinn commented Dec 22, 2015

kristinn commented Dec 22, 2015

tkak commented Jan 7, 2016

kristinn commented Jan 7, 2016

kristinn commented Apr 20, 2016

chrislovecnm commented Apr 20, 2016

kristinn commented Apr 20, 2016

chrislovecnm commented Apr 20, 2016

kristinn Apr 20, 2016

Choose a reason for hiding this comment

kristinn commented Apr 20, 2016

kristinn commented Apr 21, 2016

jen20 commented Apr 21, 2016

ghost commented Apr 26, 2020