provider/azurerm: add network security rule

[stack72]

@jen20 Scaffold the Azure RM Network Security Rule resource

• Schema
• CRUD
• Acceptance Tests
• Documentation

Test Results:

make testacc TEST=./builtin/providers/azurerm TESTARGS='-run=AzureRMNetworkSecurityRule' 2>~/tf.log
==> Checking that code complies with gofmt requirements...
go generate ./...
TF_ACC=1 go test ./builtin/providers/azurerm -v -run=AzureRMNetworkSecurityRule -timeout 120m
=== RUN   TestResourceAzureRMNetworkSecurityRuleProtocol_validation
--- PASS: TestResourceAzureRMNetworkSecurityRuleProtocol_validation (0.00s)
=== RUN   TestResourceAzureRMNetworkSecurityRuleAccess_validation
--- PASS: TestResourceAzureRMNetworkSecurityRuleAccess_validation (0.00s)
=== RUN   TestResourceAzureRMNetworkSecurityRuleDirection_validation
--- PASS: TestResourceAzureRMNetworkSecurityRuleDirection_validation (0.00s)
=== RUN   TestAccAzureRMNetworkSecurityRule_basic
--- PASS: TestAccAzureRMNetworkSecurityRule_basic (128.50s)
=== RUN   TestAccAzureRMNetworkSecurityRule_addingRules
--- PASS: TestAccAzureRMNetworkSecurityRule_addingRules (176.37s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/azurerm    304.888s

Regarding changes to azurerm_network_security_group

The changes to resource_arm_network_security_group.go were merely refactorings and flattening of the SecurityRules. The tests still pass as expected:

make testacc TEST=./builtin/providers/azurerm TESTARGS='-run=AzureRMNetworkSecurityGroup' 2>~/tf.log
==> Checking that code complies with gofmt requirements...
go generate ./...
TF_ACC=1 go test ./builtin/providers/azurerm -v -run=AzureRMNetworkSecurityGroup -timeout 120m
=== RUN   TestAccAzureRMNetworkSecurityGroup_basic
--- PASS: TestAccAzureRMNetworkSecurityGroup_basic (123.22s)
=== RUN   TestAccAzureRMNetworkSecurityGroup_addingExtraRules
--- PASS: TestAccAzureRMNetworkSecurityGroup_addingExtraRules (165.79s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/azurerm    289.027s

[jen20]

LGTM! Thanks @stack72!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.