-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provider/aws: Add support for account password policy #5029
provider/aws: Add support for account password policy #5029
Conversation
return nil | ||
} | ||
|
||
func resourceAwsIamAccountPasswordPolicyUpdate(d *schema.ResourceData, meta interface{}) error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need to do this. In the schema declaration, we can do this:
Create: resourceAwsIamAccountPasswordPolicyCreate,
Read: resourceAwsIamAccountPasswordPolicyRead,
Update: resourceAwsIamAccountPasswordPolicyCreate,
Delete: resourceAwsIamAccountPasswordPolicyDelete,
This one is also ace! If you want, you can merge and I can add acceptance tests as I have some free time today |
3c61abd
to
3639ec6
Compare
ce9c727
to
39f6eb1
Compare
This is now ready for review. |
@radeksimko this looks really good. The only small thing I would say is that we should maybe add a note to the docs saying that only 1 password policy is allowed per AWS account. Apart from that it's 👍
|
39f6eb1
to
5b4fcca
Compare
Spot on :) |
provider/aws: Add support for account password policy
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
This should allow codifying AWS account-wide password policy.
To do: