Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google_pubsub_subscription crashes when ack_deadline_seconds is provided #5110

Merged
merged 1 commit into from
Feb 23, 2016

Conversation

fd
Copy link
Contributor

@fd fd commented Feb 12, 2016

panic: interface conversion: interface is int, not int64

goroutine 41 [running]:
github.com/hashicorp/terraform/builtin/providers/google.resourcePubsubSubscriptionCreate(0xc820079020, 0x813e80, 0xc820078d80, 0x0, 0x0)
    /private/tmp/terraform20160205-18753-13bx7e7/terraform-0.6.11/src/github.com/hashicorp/terraform/builtin/providers/google/resource_pubsub_subscription.go:78 +0x4bd
github.com/hashicorp/terraform/helper/schema.(*Resource).Apply(0xc82052f980, 0xc820566630, 0xc8205e7dd0, 0x813e80, 0xc820078d80, 0x10101, 0x0, 0x0)
    /private/tmp/terraform20160205-18753-13bx7e7/terraform-0.6.11/src/github.com/hashicorp/terraform/helper/schema/resource.go:145 +0x28e
github.com/hashicorp/terraform/helper/schema.(*Provider).Apply(0xc820595080, 0xc8203e9440, 0xc820566630, 0xc8205e7dd0, 0x1, 0x0, 0x0)
    /private/tmp/terraform20160205-18753-13bx7e7/terraform-0.6.11/src/github.com/hashicorp/terraform/helper/schema/provider.go:162 +0x1ed
github.com/hashicorp/terraform/rpc.(*ResourceProviderServer).Apply(0xc8205e0100, 0xc8205e1300, 0xc8205e7ed0, 0x0, 0x0)
    /private/tmp/terraform20160205-18753-13bx7e7/terraform-0.6.11/src/github.com/hashicorp/terraform/rpc/resource_provider.go:323 +0x76
reflect.Value.call(0x7d15c0, 0x93c260, 0x13, 0x99b5f8, 0x4, 0xc82030fee8, 0x3, 0x3, 0x0, 0x0, ...)
    /usr/local/Cellar/go/1.5.3/libexec/src/reflect/value.go:432 +0x120a
reflect.Value.Call(0x7d15c0, 0x93c260, 0x13, 0xc82030fee8, 0x3, 0x3, 0x0, 0x0, 0x0)
    /usr/local/Cellar/go/1.5.3/libexec/src/reflect/value.go:300 +0xb1
net/rpc.(*service).call(0xc82052fdc0, 0xc82052fd80, 0xc8205e63e0, 0xc8203b0000, 0xc8205e0140, 0x6982c0, 0xc8205e1300, 0x16, 0x698320, 0xc8205e7ed0, ...)
    /usr/local/Cellar/go/1.5.3/libexec/src/net/rpc/server.go:383 +0x1c1
created by net/rpc.(*Server).ServeCodec
    /usr/local/Cellar/go/1.5.3/libexec/src/net/rpc/server.go:477 +0x4ac

@phinze
Copy link
Contributor

phinze commented Feb 23, 2016

LGTM, thanks for this, @fd! Going to tweak the acceptance test on master to cover this fix, will ping you as an FYI 👍

phinze added a commit that referenced this pull request Feb 23, 2016
google_pubsub_subscription crashes when ack_deadline_seconds is provided
@phinze phinze merged commit 1d67fc4 into hashicorp:master Feb 23, 2016
phinze added a commit that referenced this pull request Feb 23, 2016
terraformbot pushed a commit that referenced this pull request Feb 23, 2016
[origin/master] provider/google: cover fix in #5110
79dee04
terraformbot pushed a commit that referenced this pull request Feb 23, 2016
[origin/master] provider/google: cover fix in #5110
79dee04
terraformbot pushed a commit that referenced this pull request Feb 23, 2016
[origin/master] provider/google: cover fix in #5110
79dee04
terraformbot pushed a commit that referenced this pull request Feb 23, 2016
[origin/master] provider/google: cover fix in #5110
79dee04
terraformbot pushed a commit that referenced this pull request Feb 23, 2016
[origin/master] provider/google: cover fix in #5110
79dee04
terraformbot pushed a commit that referenced this pull request Feb 23, 2016
[origin/master] provider/google: cover fix in #5110
79dee04
terraformbot pushed a commit that referenced this pull request Feb 23, 2016
[origin/master] provider/google: cover fix in #5110
79dee04
terraformbot pushed a commit that referenced this pull request Feb 23, 2016
[origin/master] provider/google: cover fix in #5110
79dee04
terraformbot pushed a commit that referenced this pull request Feb 23, 2016
[origin/master] provider/google: cover fix in #5110
79dee04
bigkraig pushed a commit to bigkraig/terraform that referenced this pull request Mar 1, 2016
@ghost
Copy link

ghost commented Apr 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants