provider/aws: Update IAM Server Cert #5178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ated namesprovider/aws: Update IAM Server Cert to allow name_prefix, auto generated namesdiff
|
Oh hey, this fixes #4689 , which I authored. How about that... |
This was referenced Feb 17, 2016
| value := v.(string) | ||
| if len(value) > 255 { | ||
| errors = append(errors, fmt.Errorf( | ||
| "%q cannot be longer than 255 characters", k)) |
There was a problem hiding this comment.
Name here is 255 characters but name_prefix says 128. Which is correct?
There was a problem hiding this comment.
good catch, I'll update
The server cert name itself is limited to 128, fat-finger copy-paste by me (copied from you, actually 😄 )
|
@catsby 1 small question about name lengths bit apart from that LGTM! |
| ForceNew: true, | ||
| ValidateFunc: func(v interface{}, k string) (ws []string, errors []error) { | ||
| value := v.(string) | ||
| if len(value) > 30 { |
There was a problem hiding this comment.
This is kind of arbitrary but seemed sufficient...
There was a problem hiding this comment.
This looks like a good portion to allow as a prefix
|
@catsby this is also good to merge now! |
|
LGTM |
stack72
added a commit
that referenced
this pull request
Feb 22, 2016
provider/aws: Update IAM Server Cert
vancluever
pushed a commit
to paybyphone/terraform
that referenced
this pull request
Nov 17, 2016
Looks like sometimes it takes some time for IAM certificates to propagate, which can cause errors on ALB listener creation. Possibly same thing as hashicorp#5178, but for ALB now instead of ELB. This was discovered via acceptance tests, specifically the TestAccAWSALBListener_https test. Updated the creation process to wait on CertificateNotFound for a max of 5min.
stack72
pushed a commit
that referenced
this pull request
Nov 17, 2016
#10180) Looks like sometimes it takes some time for IAM certificates to propagate, which can cause errors on ALB listener creation. Possibly same thing as #5178, but for ALB now instead of ELB. This was discovered via acceptance tests, specifically the TestAccAWSALBListener_https test. Updated the creation process to wait on CertificateNotFound for a max of 5min.
stack72
pushed a commit
that referenced
this pull request
Nov 17, 2016
#10180) Looks like sometimes it takes some time for IAM certificates to propagate, which can cause errors on ALB listener creation. Possibly same thing as #5178, but for ALB now instead of ELB. This was discovered via acceptance tests, specifically the TestAccAWSALBListener_https test. Updated the creation process to wait on CertificateNotFound for a max of 5min.
jrnt30
pushed a commit
to jrnt30/terraform
that referenced
this pull request
Nov 17, 2016
hashicorp#10180) Looks like sometimes it takes some time for IAM certificates to propagate, which can cause errors on ALB listener creation. Possibly same thing as hashicorp#5178, but for ALB now instead of ELB. This was discovered via acceptance tests, specifically the TestAccAWSALBListener_https test. Updated the creation process to wait on CertificateNotFound for a max of 5min.
gusmat
pushed a commit
to gusmat/terraform
that referenced
this pull request
Dec 6, 2016
hashicorp#10180) Looks like sometimes it takes some time for IAM certificates to propagate, which can cause errors on ALB listener creation. Possibly same thing as hashicorp#5178, but for ALB now instead of ELB. This was discovered via acceptance tests, specifically the TestAccAWSALBListener_https test. Updated the creation process to wait on CertificateNotFound for a max of 5min.
fatmcgav
pushed a commit
to fatmcgav/terraform
that referenced
this pull request
Feb 27, 2017
hashicorp#10180) Looks like sometimes it takes some time for IAM certificates to propagate, which can cause errors on ALB listener creation. Possibly same thing as hashicorp#5178, but for ALB now instead of ELB. This was discovered via acceptance tests, specifically the TestAccAWSALBListener_https test. Updated the creation process to wait on CertificateNotFound for a max of 5min.
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates IAM Server Cert to allow
name_prefix, auto generated names.This will fix #5158 by allowing users to use the
create_before_destroylifecycle block with IAM Server Certificate resources.Also fixes: