Added routing rules to s3 buckets

[dminnear]

Relevant issue is #4907. This adds json routing rules to s3 bucket websites.

[jen20]

Hi @dminnear! Thanks for opening this pull request. My initial scan looks good, I'm going to pull it down locally and run the acceptance tests prior to a final review and merging now.

[dminnear]

Hi @jen20! The acceptance tests seem to pass randomly. My friend @Bowbaq suggested that s3 may be eventually consistent. I tried to write the acceptance test in the same style as the existing ones but like the existing ones it doesn't always pass.

[jen20]

Hi @dminnear - thanks for the heads up. I've run them through ten times without issue, so I'm willing to believe this functionality works for now at least! When we come back to flaky S3 tests I imagine the same fixes will apply, so I'm happy to merge for now (cc @phinze). Thanks for the contribution!

Test output below:

$ make testacc TEST=./builtin/providers/aws TESTARGS="-run TestAccAWSS3Bucket_WebsiteRoutingRules"
==> Checking that code complies with gofmt requirements...
/Users/James/Code/go/bin/stringer
go generate $(go list ./... | grep -v /vendor/)
TF_ACC=1 go test ./builtin/providers/aws -v -run TestAccAWSS3Bucket_WebsiteRoutingRules -timeout 120m
=== RUN   TestAccAWSS3Bucket_WebsiteRoutingRules
--- PASS: TestAccAWSS3Bucket_WebsiteRoutingRules (32.57s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    32.589s

$ make testacc TEST=./builtin/providers/aws TESTARGS="-run TestAccAWSS3Bucket_WebsiteRoutingRules"
==> Checking that code complies with gofmt requirements...
/Users/James/Code/go/bin/stringer
go generate $(go list ./... | grep -v /vendor/)
TF_ACC=1 go test ./builtin/providers/aws -v -run TestAccAWSS3Bucket_WebsiteRoutingRules -timeout 120m
=== RUN   TestAccAWSS3Bucket_WebsiteRoutingRules
--- PASS: TestAccAWSS3Bucket_WebsiteRoutingRules (34.06s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    34.095s

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.