helper/resource: Error shouldn't be returned in case of success

[radeksimko]

This is fixing a bug that was introduced in #5460

It is easily reproducible by running any acceptance test of a resource which uses resource.Retry, e.g. Lambda function:

make testacc TEST=./builtin/providers/aws TESTARGS='-run=AWSLambdaFunction_basic'

TF_ACC=1 go test ./builtin/providers/aws -v -run=AWSLambdaFunction_basic -timeout 120m
=== RUN   TestAccAWSLambdaFunction_basic
--- FAIL: TestAccAWSLambdaFunction_basic (29.64s)
    testing.go:148: Step 0 error: Error applying: 1 error(s) occurred:

        * aws_lambda_function.lambda_function_test: Error creating Lambda function: InvalidParameterValueException: The role defined for the function cannot be assumed by Lambda.
status code: 400, request id: *REDACTED*
FAIL
exit status 1
FAIL    github.com/hashicorp/terraform/builtin/providers/aws    29.665s
make: *** [testacc] Error 1

Any time API returned error and we retried the request, we also saved the error into resultErr. Then after few retries, even if we received no error, we still returned the resultErr we had from the last failed API call.

[phinze]

Great find / fix - thanks @radeksimko

[phinze]

LGTM

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.