Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/openstack: Fix create/delete statuses in load balancing resources for openstack provider. #5557

Merged
merged 1 commit into from
Mar 11, 2016

Conversation

pfrybar
Copy link

@pfrybar pfrybar commented Mar 10, 2016

When trying to create a complete load balancer in Openstack, I would often run into the following error:

* openstack_lb_member_v1.lb_member.1: unexpected state 'PENDING_CREATE', wanted target '[ACTIVE]'

After digging around in the code, I saw that the Pending status was different for the various LB resources (member, monitor, pool, and vip). Based on the source code for neutron lbaas, I found that the statuses should be as follows:

Create resource - 'PENDING_CREATE' - https://github.com/openstack/neutron-lbaas/blob/master/neutron_lbaas/db/loadbalancer/loadbalancer_db.py - lines 379, 593, 659, and 728.

Delete resource - 'PENDING_DELETE' - https://github.com/openstack/neutron-lbaas/blob/master/neutron_lbaas/services/loadbalancer/plugin.py - lines 167, 250, 277, and 341.

After making this change, and re-compiling the openstack provider, I have not seen the error after multiple deployments.

Note: the create resource for vip (resource_openstack_lb_vip_v1.go) already has the Pending status set to 'PENDING_CREATE'.

@pfrybar pfrybar changed the title Fix create/delete statuses in load balancing resources for openstack provider. provider/openstack: Fix create/delete statuses in load balancing resources for openstack provider. Mar 10, 2016
@jtopjian
Copy link
Contributor

Thanks so much for this!

I'll run it through the acceptance test suite as soon as I have a chance and then merge this in.

@pfrybar
Copy link
Author

pfrybar commented Mar 10, 2016

Sounds good!

@jtopjian
Copy link
Contributor

All looks good to me! Thanks again for fixing this.

jtopjian added a commit that referenced this pull request Mar 11, 2016
provider/openstack: Fix create/delete statuses in load balancing resources for openstack provider.
@jtopjian jtopjian merged commit edb30d5 into hashicorp:master Mar 11, 2016
@ghost
Copy link

ghost commented Apr 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants