provider/template: warn when template specified as path #5563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out the BC code allowed users to move from `filename` to `template` to squash the warning without having to switch from template paths to template contents. Here we warn when `template` is specified as a path so we can remove the functionality in the future and remove this source of confusion. refs #3732
|
LGTM pending Travis |
phinze
added a commit
that referenced
this pull request
Mar 10, 2016
provider/template: warn when template specified as path
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out the BC code allowed users to move from
filenametotemplateto squash the warning without having to switch from templatepaths to template contents.
Here we warn when
templateis specified as a path so we can remove thefunctionality in the future and remove this source of confusion.
refs #3732