Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panic in digital_ocean_droplet if resp is nil #5588

Merged
merged 1 commit into from
Mar 14, 2016

Conversation

jen20
Copy link
Contributor

@jen20 jen20 commented Mar 11, 2016

This probably occurs if there is transport failure, though I could not reproduce it locally. The report of the panic indicates the source of the problem though - we should fail gracefully in this case.

Fixes #5583.

@phinze
Copy link
Contributor

phinze commented Mar 11, 2016

LGTM

stack72 added a commit that referenced this pull request Mar 14, 2016
Fix panic in digital_ocean_droplet if resp is nil
@stack72 stack72 merged commit 908a2cc into master Mar 14, 2016
@stack72 stack72 deleted the b-digital-ocean-droplet-panic branch March 14, 2016 12:37
@jen20 jen20 mentioned this pull request Mar 21, 2016
jen20 added a commit that referenced this pull request Mar 21, 2016
This applies the same fix to `digitalocean_ssh_key` as #5588 applies to
droplets. Fixes #5402. The report there gives weight to my theory that
this occurs when there are transport issues.
@ghost
Copy link

ghost commented Apr 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic error for digitalocean_droplet
3 participants