Added KMS alias name_prefix

[iceycake]

Instead of a static KMS alias name, it allows either name_prefix or generate unique name.

[catsby]

since we're now modifying what we get from the config regarding the name, we need to make sure we use the d.Id() in resourceAwsKmsAliasRead, because d.Get("name") may now return ""

[iceycake]

Do I need to make any change here? The name was in the old implementation so I just keep it. I saw similar implementation with security_group. Please let me know if I need to fix this for the merge or it's something we can deal with with another pull request.

[catsby]

Looks good! I left a note about the usage of name vs. Id, and I believe we'll need an update to the documentation as well before we can merge.

[catsby]

Also, I ran the TestAccAWSKmsAlias_no_name test and got a failure, can you take a look?

--- FAIL: TestAccAWSKmsAlias_no_name (143.46s)
    testing.go:148: Step 0 error: Error applying: 1 error(s) occurred:

        * aws_kms_alias.nothing: ValidationException: Alias must start with the prefix "alias/". Please see http://docs.aws.amazon.com/kms/latest/developerguide/programming-aliases.html
            status code: 400, request id: 5ccc078e-e7da-11

[iceycake]

Is this ready to be accepted?

[stack72]

Hi @iceycake

thanks so much for fixing up the rest of the rest as per @catsby's notes

The tests now pass as follows so this looks good to merge

make testacc TEST=./builtin/providers/azurerm TESTARGS='-run=TestAccAWSKmsAlias' 2>~/tf.log
==> Checking that code complies with gofmt requirements...
/Users/stacko/Code/go/bin/stringer
go generate $(go list ./... | grep -v /vendor/)
TF_ACC=1 go test ./builtin/providers/azurerm -v -run=TestAccAWSKmsAlias -timeout 120m
PASS
ok      github.com/hashicorp/terraform/builtin/providers/azurerm    0.011s

[stack72]

Merged in 9cfcfed

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.