Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws: Fix CloudFormation update for parameters & capabilities if not modified #5603

Merged
merged 2 commits into from
Mar 13, 2016

Conversation

radeksimko
Copy link
Member

Based on @olegch's work from #5264

I resolved conflicts, omitted unrelated changes in the build script and enhanced existing acceptance test to cover this bug.

Test plan

make testacc TEST=./builtin/providers/aws TESTARGS='-run=AWSCloudFormation_allAttributes'
TF_ACC=1 go test ./builtin/providers/aws -v -run=AWSCloudFormation_allAttributes -timeout 120m
=== RUN   TestAccAWSCloudFormation_allAttributes
--- PASS: TestAccAWSCloudFormation_allAttributes (153.44s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    153.464s

@radeksimko
Copy link
Member Author

I'm merging this myself as it's effectively code from an existing PR (#5264) with improved tests.

Feel free to review this afterwards though.

@ghost
Copy link

ghost commented Apr 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants