provider/aws: send Terraform version in User-Agent

[phinze]

No description provided.

[radeksimko]

Closes #5020

Do you think it would make sense to make this optionally/partially modifiable via ENV variable, so that other tools using Terraform, like Atlas can also add their version there or you think it's not worth it or there isn't much value in knowing what Atlas version was used per request?

[phinze]

Do you think it would make sense to make this optionally/partially modifiable via ENV variable

Sure, wouldn't hurt!

[radeksimko]

Also as this is now overriding the original value (AWS Go SDK version), do you think there is value in putting it back into the full string?

So that the full User-Agent string would contain:

1. (optional) Atlas/3rd party tool version that is using Terraform
2. Terraform version
3. AWS Go SDK version

I'm not sure if the version is nicely exposed from the SDK though...

[phinze]

@radeksimko it's not overriding, current user agent string looks like:

User-Agent: aws-sdk-go/1.1.2 (go1.6; darwin; amd64) terraform/0.6.13 (dev)

[radeksimko]

it's not overriding

right, because of PushBackNamed... that's good then, so the optional part can be handled the same way I assume?

[jen20]

Potential bikeshedding, do we want to put terraform/version before aws-sdk-go/version? Otherwise LGTM!

[phinze]

Ok:

• Moved to PushFront so TF version shows up before aws-sdk-go version
• Going to hold off on external customizability since it's slightly trickier than a one-liner and I'd like to land this now.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.