Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLC update: tests and alias #5785

Merged
merged 2 commits into from
Mar 22, 2016
Merged

CLC update: tests and alias #5785

merged 2 commits into from
Mar 22, 2016

Conversation

ack
Copy link
Contributor

@ack ack commented Mar 22, 2016

customer requested account alias be optionally available. updated tests as per previous PR discussion

ack referenced this pull request in ack/terraform Mar 22, 2016
@phinze
Copy link
Contributor

phinze commented Mar 22, 2016

Hi @ack - thanks for this!

I see builtin/providers/clc/resource_clc_load_balancer_test.go is going entirely away here - is that because it's exercised elsewhere?

If that's the case, I think we should keep a file there with a comment pointing to where it is tested, just because the "every resource has a test file sibling" is such a pattern for us.

@ack ack force-pushed the clc-patches branch 2 times, most recently from fa3c9ec to d9104f7 Compare March 22, 2016 19:06
@ack
Copy link
Contributor Author

ack commented Mar 22, 2016

gotcha, resurrected an empty test

@phinze
Copy link
Contributor

phinze commented Mar 22, 2016

LGTM

ack added a commit that referenced this pull request Mar 22, 2016
CLC update: tests and alias
@ack ack merged commit fdc105a into hashicorp:master Mar 22, 2016
@phinze
Copy link
Contributor

phinze commented Mar 22, 2016

Congrats on your first merge 😄

There's a user facing change here - so let's have you add a line to the changelog under IMPROVEMENTS about the fact that you can now set an account alias. You can follow the patterns elsewhere in the file and commit right to master. Most of us just use the GitHub edit button just after merging to keep the workflow lightweight.

@fatmcgav
Copy link
Contributor

Cheers for the quick turnaround @ack...

@ack ack deleted the clc-patches branch May 4, 2016 17:03
@ghost
Copy link

ghost commented Apr 26, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants