Fix Image Destroy bug. #3609 #3771

[rhyas]

This is an updated pull request to replace #3771 to fix the discrepancies with the test case, as well as solve the problem proposed with #3609. Destroy should remove the images as a resource. Long term, there could probably be a "save" option added to the image resource that could force them not to be destroyed, but the expected action on a destroy is just what it says.

[stack72]

Hi @rhyas

Thanks so much for the PR - the functionality seems correct to me. I have discussed the func with @jen20 and he also agrees

The tests pass as expected:

TF_LOG=1 make testacc TEST=./builtin/providers/docker TESTARGS='-run=TestAccDockerImage' 2>~/tf.log
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /vendor/)
TF_ACC=1 go test ./builtin/providers/docker -v -run=TestAccDockerImage -timeout 120m
=== RUN   TestAccDockerImage_basic
--- PASS: TestAccDockerImage_basic (8.78s)
=== RUN   TestAccDockerImage_private
--- PASS: TestAccDockerImage_private (3.35s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/docker 12.147s

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.