provider/openstack: Fix Disabling DHCP on Subnets #6052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a bug where "false" was not correctly being passed to the subnet creation and therefore enabling DHCP on all subnets.
jtopjian
added a commit
to jtopjian/terraform
that referenced
this pull request
May 23, 2016
The openstack_networking_subnet_v2 resource was originally designed to have DHCP disabled by default; however, a bug in the original implementation caused DHCP to always be enabled and never be disabled. This bug was fixed in hashicorp#6052. Recent discussions have shown that users prefer if DHCP is enabled by default. This commit implements makes the change.
cristicalin
pushed a commit
to cristicalin/terraform
that referenced
this pull request
May 24, 2016
The openstack_networking_subnet_v2 resource was originally designed to have DHCP disabled by default; however, a bug in the original implementation caused DHCP to always be enabled and never be disabled. This bug was fixed in hashicorp#6052. Recent discussions have shown that users prefer if DHCP is enabled by default. This commit implements makes the change.
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a bug where "false" was not correctly being passed to
the subnet creation and therefore enabling DHCP on all subnets.