provider/aws: Updating CloudFront distribution to correct LoggingConfig #6407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return err | ||
| } | ||
| } else { | ||
| err = d.Set("logging_config", []interface{}{}) |
There was a problem hiding this comment.
Hey @jrnt30, I think right here, you'd want to do the following instead:
err = d.Set("logging_config", schema.NewSet(loggingConfigHash, []interface{}{}))
The idea here being that even though it's an empty set you still probably want to pass a *schema.Set and the correct hash function.
…f disabled - Addresses the issue when local state file has logging_config populated and the user disables the configuration via the UI (or in this case an application of the TF config). This will now properly set the logging_config during the read operation and identify the state as diverging Fixes hashicorp#6390
jrnt30
force-pushed
the
GH-6390-Logging-config-refresh
branch
from
98bcea6
to
43717e9
Compare
|
Excellent, thanks! |
bigkraig
pushed a commit
to ticketmaster/terraform
that referenced
this pull request
May 5, 2016
…f disabled (hashicorp#6407) - Addresses the issue when local state file has logging_config populated and the user disables the configuration via the UI (or in this case an application of the TF config). This will now properly set the logging_config during the read operation and identify the state as diverging Fixes hashicorp#6390
bigkraig
pushed a commit
to ticketmaster/terraform
that referenced
this pull request
May 5, 2016
…f disabled (hashicorp#6407) - Addresses the issue when local state file has logging_config populated and the user disables the configuration via the UI (or in this case an application of the TF config). This will now properly set the logging_config during the read operation and identify the state as diverging Fixes hashicorp#6390
xsellier
pushed a commit
to xsellier/terraform
that referenced
this pull request
May 17, 2016
…f disabled (hashicorp#6407) - Addresses the issue when local state file has logging_config populated and the user disables the configuration via the UI (or in this case an application of the TF config). This will now properly set the logging_config during the read operation and identify the state as diverging Fixes hashicorp#6390
cristicalin
pushed a commit
to cristicalin/terraform
that referenced
this pull request
May 24, 2016
…f disabled (hashicorp#6407) - Addresses the issue when local state file has logging_config populated and the user disables the configuration via the UI (or in this case an application of the TF config). This will now properly set the logging_config during the read operation and identify the state as diverging Fixes hashicorp#6390
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
disables the configuration via the UI (or in this case an
application of the TF config). This will now properly set the
logging_config during the read operation and identify the state as
diverging
Fixes #6390