provider/aws: Fix issue replacing Network ACL Relationship #6421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…has already moved
|
LGTM! |
bigkraig
pushed a commit
to ticketmaster/terraform
that referenced
this pull request
May 5, 2016
bigkraig
pushed a commit
to ticketmaster/terraform
that referenced
this pull request
May 5, 2016
xsellier
pushed a commit
to xsellier/terraform
that referenced
this pull request
May 17, 2016
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible that during an attempt to replace this
association, the Subnet in question has already been moved to
another ACL. This can happen if you're destroying a network acl
and simultaneously re-associating it's subnet(s) with another
ACL; Terraform may have already re-associated the subnet(s) by
the time we attempt to destroy them, even between the time we
list them and then try to destroy them. In this case, the
association we're trying to replace will no longer exist and
this call will fail. Here we trap that error and fail
gracefully; the association we tried to replace gone, we trust
someone else has taken ownership.
Fixes
TestAccAWSNetworkAcl_SubnetChangethat's been failing for some time