provider/aws: Improve error handling in IAM Server Certificates #6442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -51,6 +51,41 @@ func TestAccAWSIAMServerCertificate_name_prefix(t *testing.T) { | |||
| }) | |||
| } | |||
|
|
|||
| func TestAccAWSIAMServerCertificate_recreate(t *testing.T) { | |||
There was a problem hiding this comment.
Conventionally I've been calling these _disappears tests.
|
LGTM! Couple of optional notes inline on the test. |
|
Applied feedback in 4efb067, going to go ahead and pull this in |
bigkraig
pushed a commit
to ticketmaster/terraform
that referenced
this pull request
May 5, 2016
…icorp#6442) * provider/aws: Improve error handling in IAM Server Certificates * rename test, add additional empty check
bigkraig
pushed a commit
to ticketmaster/terraform
that referenced
this pull request
May 5, 2016
…icorp#6442) * provider/aws: Improve error handling in IAM Server Certificates * rename test, add additional empty check
xsellier
pushed a commit
to xsellier/terraform
that referenced
this pull request
May 17, 2016
…icorp#6442) * provider/aws: Improve error handling in IAM Server Certificates * rename test, add additional empty check
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does 3 things:
READ, instead of throwing an error. This will correctly prompt to re-create if in aplanDELETE(API returns aNoSuchEntityerror), instead of throwing an error locally and blocking progress