provider/aws: Add CloudFront hosted_zone_id attribute #6530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the hosted_zone_id attribute, which aliases to the Route 53 zone ID that can be used to route Alias Resource Record Sets to. This fixes hashicorp#6489.
vancluever
force-pushed
the
paybyphone_GH_6489
branch
from
e8e1930
to
d523014
Compare
|
Hi @vancluever Thanks so much - this looks like a simple addition :) P. |
cristicalin
pushed a commit
to cristicalin/terraform
that referenced
this pull request
May 24, 2016
Added the hosted_zone_id attribute, which aliases to the Route 53 zone ID that can be used to route Alias Resource Record Sets to. This fixes hashicorp#6489.
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: #6489
Back by popular demand ;)
This adds the
hosted_zone_idattribute to theaws_cloudfront_distributionresource, which, at the time, is currently just an alias forZ2FDTNDATAQYW2. This ultimately makes using the resource more semantic, allowing an easy place to reference the zone ID from and also a natural dependency path.Docs included, and test hooked into the first acceptance test.