Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/google: atomic Cloud DNS record changes #6575

Merged
merged 1 commit into from
Aug 8, 2016

Conversation

billf
Copy link
Contributor

@billf billf commented May 10, 2016

Closes #6129

@billf
Copy link
Contributor Author

billf commented May 27, 2016

cc: @evandbrown

@stack72
Copy link
Contributor

stack72 commented Aug 8, 2016

Hi @billf

This LGTM! Thanks for the contribution here :)

% make testacc TEST=./builtin/providers/google TESTARGS='-run=TestAccDnsRecordSet_'                                           1 ↵
==> Checking that code complies with gofmt requirements...
/Users/stacko/Code/go/bin/stringer
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/08/08 12:30:39 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/google -v -run=TestAccDnsRecordSet_ -timeout 120m
=== RUN   TestAccDnsRecordSet_basic
--- PASS: TestAccDnsRecordSet_basic (44.18s)
=== RUN   TestAccDnsRecordSet_modify
--- PASS: TestAccDnsRecordSet_modify (89.34s)
=== RUN   TestAccDnsRecordSet_changeType
--- PASS: TestAccDnsRecordSet_changeType (64.72s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/google 198.265s

@stack72 stack72 merged commit 9ddb2fd into hashicorp:master Aug 8, 2016
@billf billf deleted the f-gcp-atomic-dns-update branch August 8, 2016 22:50
@ghost
Copy link

ghost commented Apr 23, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_dns_record_set has no Resource.UpdateFunc
3 participants