provider/datadog: add a timeboard resource #6900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bedwards
changed the title
…-api to support read-only option.
|
I added the read-only option. That required updating the vendored go-datadog-api library. I did a push force to keep it in one commit. |
|
👍 LGTM! |
|
Hi all This LGTM! Paul |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I work with Otto Jongerius at Atlassian. I extended his Datadog provider with support for Timeboards. Datadog has two types of dashboards, timeboards and screenboards. On timeboards there is a single time range control at the top that affect all the graphs on the dashboard at once. Screenboards have more options as far as layout, support more widgets, and charts can have different, locked-in time ranges. This PR adds support for timeboards.
I manually tested with the datadog_timeboard_v0.6.16 in this fork. My changes (a single commit) are the same in both branches, but I had to build against the v0.6.16 tag to use it with that released version of terraform.
I updated the website docs.
I included an acceptance test.