provider/azurerm: DNS CNAME resource wasn't posting records #7113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Azure changed the API for CNAME at some point and since then we haven't been creating CNAME records. The API changes from []records to a single record This PR changes the schema for dns cnames to have a record parameter and adds a deprecation warning around records. Talked with @jen20 on this and we decided that it's currently broken and we should handle this as part of 0.7 where there are other breaking changes ``` TF_LOG=1 make testacc TEST=./builtin/providers/azurerm TESTARGS='-run=TestAccAzureRMDnsCNameRecord' 2>~/tf.log ==> Checking that code complies with gofmt requirements... go generate $(go list ./... | grep -v /vendor/) TF_ACC=1 go test ./builtin/providers/azurerm -v -run=TestAccAzureRMDnsCNameRecord -timeout 120m === RUN TestAccAzureRMDnsCNameRecord_basic --- PASS: TestAccAzureRMDnsCNameRecord_basic (97.22s) === RUN TestAccAzureRMDnsCNameRecord_subdomain --- PASS: TestAccAzureRMDnsCNameRecord_subdomain (94.94s) === RUN TestAccAzureRMDnsCNameRecord_updateRecords --- PASS: TestAccAzureRMDnsCNameRecord_updateRecords (116.62s) ```
| Optional: true, | ||
| Elem: &schema.Schema{Type: schema.TypeString}, | ||
| Set: schema.HashString, | ||
| Deprecated: "Use `record` instead. This attribute will be removed in a future version", |
There was a problem hiding this comment.
I believe we have Removed which is an error instead of a warning. I think that's what you want here since we don't handle "records" anymore right?
|
Agreed with the "currently broken - fix w/ 0.7" strategy. LGTM! Merge is all yours and add a note to the top of the changelog when you do. 👍 |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Azure changed the API for CNAME at some point and since then we haven't
been creating CNAME records. The API changes from []records to a single
record
This PR changes the schema for dns cnames to have a record parameter and
adds a deprecation warning around records. Talked with @jen20 on this
and we decided that it's currently broken and we should handle this as
part of 0.7 where there are other breaking changes