Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provider/aws: Retry RouteTable Route/Assocation creation #7156

Merged
merged 3 commits into from
Jun 14, 2016
Merged

provider/aws: Retry RouteTable Route/Assocation creation #7156

merged 3 commits into from
Jun 14, 2016

Conversation

catsby
Copy link
Contributor

@catsby catsby commented Jun 13, 2016

Retry the creation of a Route Table Association. Eventual Consistency Bandaid for #7104

@catsby
Copy link
Contributor Author

catsby commented Jun 13, 2016 

TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSRouteTable_ -timeout 120m
=== RUN   TestAccAWSRouteTable_importBasic
--- PASS: TestAccAWSRouteTable_importBasic (33.23s)
=== RUN   TestAccAWSRouteTable_basic
--- PASS: TestAccAWSRouteTable_basic (45.50s)
=== RUN   TestAccAWSRouteTable_instance
--- PASS: TestAccAWSRouteTable_instance (121.86s)
=== RUN   TestAccAWSRouteTable_tags
--- PASS: TestAccAWSRouteTable_tags (28.59s)
=== RUN   TestAccAWSRouteTable_vgwRoutePropagation
--- PASS: TestAccAWSRouteTable_vgwRoutePropagation (31.96s)

@catsby catsby changed the title provider/aws: Retry RouteTable Assocation creation provider/aws: Retry RouteTable Route/Assocation creation Jun 13, 2016
@catsby catsby mentioned this pull request Jun 13, 2016
Closed
jbardin
jbardin reviewed Jun 14, 2016
View reviewed changes
builtin/providers/aws/resource_aws_route_table.go
_, err := conn.CreateRoute(&opts)
if err != nil {
if awsErr, ok := err.(awserr.Error); ok {
if awsErr.Code() == "InvalidRouteTableID.NotFound" && strings.Contains(awsErr.Message(), "does not exist") {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need the check for "does not exist" here? Seems like InvalidRouteTableID.NotFound should cover this case.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, probably don't need that. Removed in a6123ed

@jbardin
Copy link
Member

jbardin commented Jun 14, 2016

Other than the extra string comparisons, this LGTM provided travis passes.

@catsby catsby force-pushed the b-aws-retry-route-association branch from a6123ed to 75df603 Compare June 14, 2016 20:28
@catsby catsby merged commit 627efa2 into master Jun 14, 2016
@stack72 stack72 deleted the b-aws-retry-route-association branch June 23, 2016 08:10
@ghost
Copy link

ghost commented Apr 24, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
bug provider/aws
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@catsby @jbardin