Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provider/cloudstack: add affinity_group_names #7242

Merged
merged 1 commit into from
Jun 27, 2016
Merged

provider/cloudstack: add affinity_group_names #7242

merged 1 commit into from
Jun 27, 2016

Conversation

mcanevet
Copy link
Contributor

No description provided.

@mcanevet mcanevet mentioned this pull request Jun 22, 2016
Closed
svanharmelen
svanharmelen reviewed Jun 25, 2016
View reviewed changes
builtin/providers/cloudstack/resource_cloudstack_instance.go
Type: schema.TypeSet,
Optional: true,
Computed: true,
ForceNew: true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure changes to the attribute require a new instance to take effect?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checked and this is not needed: http://cloudstack.apache.org/docs/api/apidocs-4.8/root_admin/updateVMAffinityGroup.html So we can lose the ForceNew

@svanharmelen
Copy link
Contributor

@mcanevet thanks for the PR! I have two small question and you need to rebase the PR, other then that it looks good.

@mcanevet mcanevet force-pushed the cloudstack_affinitygroupnames branch 2 times, most recently from e60cdc9 to c93c258 Compare June 27, 2016 07:31
@mcanevet
Copy link
Contributor Author

@svanharmelen fixed

@svanharmelen
Copy link
Contributor

@mcanevet thanks... Noticed the build fails, which is because of the Computed flag. Since we do not read back this data in the read func, the Computed flag doesn't make much sense here. So it's save to just remove that flag and then we should be good to go...

@mcanevet mcanevet force-pushed the cloudstack_affinitygroupnames branch from f3079f8 to 3d9bdaf Compare June 27, 2016 07:55
@mcanevet
Copy link
Contributor Author

@svanharmelen Travis is happy now!

@svanharmelen
Copy link
Contributor

Thanks!

@svanharmelen svanharmelen merged commit dd59ceb into hashicorp:master Jun 27, 2016
@mcanevet mcanevet deleted the cloudstack_affinitygroupnames branch June 27, 2016 08:51
@ghost
Copy link

ghost commented Apr 24, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement provider/cloudstack
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcanevet @svanharmelen @jen20