Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Add dns_name to aws_efs_mount_target #7428

Merged
merged 1 commit into from
Jun 30, 2016

Conversation

radeksimko
Copy link
Member

This can be useful for people who prefer DNS names over IPs in configs.

It also expands the permissions scope for aws_efs_mount_target as ec2:DescribeSubnets is now required. I think it's worth expanding, given the convenience.

Test plan

make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSEFSMountTarget'
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSEFSMountTarget -timeout 120m
=== RUN   TestAccAWSEFSMountTarget_basic
--- PASS: TestAccAWSEFSMountTarget_basic (416.17s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    416.193s

@stack72
Copy link
Contributor

stack72 commented Jun 30, 2016

LGTM! Merge at will :)

@radeksimko radeksimko merged commit b544819 into hashicorp:master Jun 30, 2016
@radeksimko radeksimko deleted the f-efs-target-hostname branch June 30, 2016 11:40
@ghost
Copy link

ghost commented Apr 24, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants