core: Return an error when there's no remote state #7464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When refreshing remote state, indicate when no state file was found with an ErrRemoteStateNotFound error. This prevents us from inadvertantly getting a nil state into a terraform.State where we assume there's always a root module.
|
Cool so this addresses the LGTM |
jbardin
added a commit
that referenced
this pull request
Jul 6, 2016
The error for a nil remote state was showing up in other places. While
we could check for the error on all calls to Refresh(), this restores
the previous behavior, while preventing possible nil values in the
state.
The effect here is the same, because rather than the RefreshState
switching on
cached != nil && durable == nil
it will switch on
durable.Serial < cached.Serial
which sets the same value to RefreshResult().
jbardin
added a commit
that referenced
this pull request
Jul 6, 2016
Take a new approach to handling a nil remote state payload. Rather than
define an error indicating a nil remote state (which would need to be
moved to an internal package in order to be imported by all packages
which could use it), we create an empty terraform.State with a Serial of
-1 to ensure it's always superseded by any other state. This restores
the previous behavior, while still preventing possible nil values in the
state.
The effect here is the same, because rather than the RefreshState
switching on
cached != nil && durable == nil
it will switch on
durable.Serial < cached.Serial
which sets the same value to RefreshResult().
jbardin
added a commit
that referenced
this pull request
Jul 7, 2016
Take a new approach to handling a nil remote state payload. Rather than
define an error indicating a nil remote state (which would need to be
moved to an internal package in order to be imported by all packages
which could use it), we create an empty terraform.State with a Serial of
-1 to ensure it's always superseded by any other state. This restores
the previous behavior, while still preventing possible nil values in the
state.
The effect here is the same, because rather than the RefreshState
switching on
cached != nil && durable == nil
it will switch on
durable.Serial < cached.Serial
which sets the same value to RefreshResult().
jbardin
added a commit
that referenced
this pull request
Jul 7, 2016
Revert back to using a nil state. The external usage of the state shoudl always check the Empty() method.
jbardin
added a commit
that referenced
this pull request
Jul 7, 2016
Revert #7464 and allow an empty state
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When refreshing remote state, indicate when no state file was found with
an ErrRemoteStateNotFound error. This prevents us from inadvertantly
getting a nil state into a terraform.State where we assume there's
always a root module.
Fixes #7455