Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gh 2087 consul service resource #7508

Merged
merged 20 commits into from
Jul 26, 2016

Conversation

maxenglander
Copy link
Contributor

I accidentally deleted PR #3687 - this is (very nearly) the same PR, re-opened.

… create resource works; TODO support more fields and add tests
… keys, can be read (refreshed) and deleted
@nanoz
Copy link

nanoz commented Jul 25, 2016

Thanks for your work on this ! This is gonna be very useful to register RDS and Elasticache instances :)

@jrnt30
Copy link
Contributor

jrnt30 commented Jul 25, 2016

Fixes #2087

@stack72
Copy link
Contributor

stack72 commented Jul 26, 2016

This LGTM!

% make testacc TEST=./builtin/providers/consul TESTARGS='-run=TestAccConsul'                                 
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
TF_ACC=1 go test ./builtin/providers/consul -v -run=TestAccConsul -timeout 120m
=== RUN   TestAccConsulAgentService_basic
--- PASS: TestAccConsulAgentService_basic (0.04s)
=== RUN   TestAccConsulCatalogEntry_basic
--- PASS: TestAccConsulCatalogEntry_basic (0.03s)
=== RUN   TestAccConsulKeyPrefix_basic
--- PASS: TestAccConsulKeyPrefix_basic (0.09s)
=== RUN   TestAccConsulKeys_basic
--- PASS: TestAccConsulKeys_basic (0.06s)
=== RUN   TestAccConsulNode_basic
--- PASS: TestAccConsulNode_basic (0.02s)
=== RUN   TestAccConsulService_basic
--- PASS: TestAccConsulService_basic (0.02s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/consul 0.272s

@stack72 stack72 merged commit 6e40210 into hashicorp:master Jul 26, 2016
@stack72
Copy link
Contributor

stack72 commented Jul 26, 2016

Manually merged as a small change was made to the tests in (47c274f)

@maxenglander
Copy link
Contributor Author

Thanks @stack72!

@ghost
Copy link

ghost commented Apr 24, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants