Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Safely get ELB values #7585

Merged
merged 1 commit into from
Jul 13, 2016
Merged

Conversation

catsby
Copy link
Contributor

@catsby catsby commented Jul 11, 2016

Removes dereferences to avoid possible nil pointer dereferences crashes; d.Set can safely handle nil values.

Fixes #7555

- removes dereferences to avoid nil crashes
@catsby
Copy link
Contributor Author

catsby commented Jul 11, 2016

TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSELB_ -timeout 120m
=== RUN   TestAccAWSELB_importBasic
--- PASS: TestAccAWSELB_importBasic (24.12s)
=== RUN   TestAccAWSELB_basic
--- PASS: TestAccAWSELB_basic (21.92s)
=== RUN   TestAccAWSELB_fullCharacterRange
--- PASS: TestAccAWSELB_fullCharacterRange (20.90s)
=== RUN   TestAccAWSELB_AccessLogs
--- PASS: TestAccAWSELB_AccessLogs (49.66s)
=== RUN   TestAccAWSELB_generatedName
--- PASS: TestAccAWSELB_generatedName (18.90s)
=== RUN   TestAccAWSELB_availabilityZones
--- PASS: TestAccAWSELB_availabilityZones (40.25s)
=== RUN   TestAccAWSELB_tags
--- PASS: TestAccAWSELB_tags (33.27s)
=== RUN   TestAccAWSELB_iam_server_cert
--- PASS: TestAccAWSELB_iam_server_cert (39.06s)
=== RUN   TestAccAWSELB_InstanceAttaching
--- PASS: TestAccAWSELB_InstanceAttaching (113.72s)
=== RUN   TestAccAWSELB_HealthCheck
--- PASS: TestAccAWSELB_HealthCheck (17.98s)
=== RUN   TestAccAWSELB_Timeout
--- PASS: TestAccAWSELB_Timeout (16.05s)
=== RUN   TestAccAWSELB_ConnectionDraining
--- PASS: TestAccAWSELB_ConnectionDraining (17.44s)
=== RUN   TestAccAWSELB_SecurityGroups
--- PASS: TestAccAWSELB_SecurityGroups (31.70s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    444.979s
Test:

@stack72
Copy link
Contributor

stack72 commented Jul 11, 2016

LGTM!

@stack72 stack72 merged commit 3cea291 into master Jul 13, 2016
@stack72 stack72 deleted the b-aws-elb-safely-reference branch July 13, 2016 09:08
iceycake pushed a commit to ticketmaster/terraform that referenced this pull request Jul 22, 2016
- removes dereferences to avoid nil crashes
@ghost
Copy link

ghost commented Apr 24, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terraform crash when creating ELB in Eucalyptus
2 participants