provider/aws: Fix issue updating ElasticBeanstalk Environment templates

[catsby]

Fixes #6603 , only set the TemplateName in a request if it's not empty. Includes regression test.

[stack72]

Currently running the tests :) LGTM (pending test results)

[stack72]

@catsby merge at will :)

% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSBeanstalkEnv_'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSBeanstalkEnv_ -timeout 120m
=== RUN   TestAccAWSBeanstalkEnv_basic
--- PASS: TestAccAWSBeanstalkEnv_basic (404.18s)
=== RUN   TestAccAWSBeanstalkEnv_tier
--- PASS: TestAccAWSBeanstalkEnv_tier (556.02s)
=== RUN   TestAccAWSBeanstalkEnv_outputs
--- PASS: TestAccAWSBeanstalkEnv_outputs (412.88s)
=== RUN   TestAccAWSBeanstalkEnv_cname_prefix
--- PASS: TestAccAWSBeanstalkEnv_cname_prefix (395.37s)
=== RUN   TestAccAWSBeanstalkEnv_config
--- PASS: TestAccAWSBeanstalkEnv_config (549.56s)
=== RUN   TestAccAWSBeanstalkEnv_resource
--- PASS: TestAccAWSBeanstalkEnv_resource (373.34s)
=== RUN   TestAccAWSBeanstalkEnv_vpc
--- PASS: TestAccAWSBeanstalkEnv_vpc (537.84s)
=== RUN   TestAccAWSBeanstalkEnv_template_change
--- PASS: TestAccAWSBeanstalkEnv_template_change (692.54s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    3921.751s

[dharrisio]

@catsby @stack72 Just a quick note on the test. It may fail depending on the aws account running the tests (#5922). Not sure what a good solution here is though, as the stack name needs to change. The only thing I can think of is to look up the available solution stacks when the tests are being run.

[catsby]

The only thing I can think of is to look up the available solution stacks when the tests are being run.

I have plans for a ElasticBeanstalk Stack Data Source, so these things can be looked up. But they are just plans at the moment. For now, these tests pass with our Terraform Acceptance test account, so we'll roll with it 👍

Thanks for the thoughts though!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.