providers/google: Add google_compute_image resource

[evandbrown]

This change introduces the google_compute_image resource, which allows
Terraform users to create a bootable VM image from a raw disk tarball
stored in Google Cloud Storage. The google_compute_image resource
may be referenced as a boot image for a google_compute_instance.

[radeksimko]

More idiomatic way to achieve the same thing may be

if v, ok := d.GetOk("description"); ok {

😉

[stack72]

Hi @evandbrown

If you could rebase this, then we can get it tested and merged :)

Thanks

Paul

[evandbrown]

@stack72 Done!

Output of relevant acceptance tests:

$ make testacc TEST=./builtin/providers/google GOOGLE_PROJECT=redacted GOOGLE_REGION=us-central1 TESTARGS='-run=TestAccComputeImage...'
==> Checking that code complies with gofmt requirements...
/home/evanbrown/dev/go-workspaces/terraform/bin/stringer
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/08/07 21:31:24 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/google -v -run=TestAccComputeImage... -timeout 120m
=== RUN   TestAccComputeImage_basic
--- PASS: TestAccComputeImage_basic (75.34s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/google 75.466s

[stack72]

@evandbrown looks like the build fails - looks like there are go vet issues

P.

[stack72]

@evandbrown ping - we have some go vet errors :)

# github.com/hashicorp/terraform/builtin/providers/google
builtin/providers/google/resource_compute_image.go:118: not enough arguments in call to computeOperationWaitGlobal
builtin/providers/google/resource_compute_image.go:169: not enough arguments in call to computeOperationWaitGlobal

[evandbrown]

@stack72 That's embarrassing! Just rebased a fix that should fix...

[stack72]

spot on :) Thanks! running tests now

[stack72]

% make testacc TEST=./builtin/providers/google TESTARGS='-run=TestAccComputeImage'           1 ↵
==> Checking that code complies with gofmt requirements...
/Users/stacko/Code/go/bin/stringer
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/08/10 17:11:13 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/google -v -run=TestAccComputeImage -timeout 120m
=== RUN   TestAccComputeImage_basic
--- PASS: TestAccComputeImage_basic (95.12s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/google 95.132s

:)

[stack72]

Will merge when travis goes green!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.