Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/statuscake: Add support for contact-group id in statuscake test #8417

Merged
merged 1 commit into from
Aug 28, 2016

Conversation

MrPink
Copy link

@MrPink MrPink commented Aug 23, 2016

Solves #8416

Adds 1 new parameter:

  • contact_id

This will be used to link a statuscake test resource to an existing contact group, further work is required for managing a statuscake contact group resource.

@stack72 stack72 self-assigned this Aug 28, 2016
@stack72 stack72 merged commit dfa917b into hashicorp:master Aug 28, 2016
@stack72
Copy link
Contributor

stack72 commented Aug 28, 2016

Hi @MrPink

thanks so much for the PR here - the functionality works as expected. I made 1 addition, to add it to the documentation b158cbc

Other than that, the tests look good:

% make testacc TEST=./builtin/providers/statuscake TESTARGS='-run=Test'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/08/28 23:50:37 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/statuscake -v -run=Test -timeout 120m
=== RUN   TestProvider
--- PASS: TestProvider (0.00s)
=== RUN   TestProvider_impl
--- PASS: TestProvider_impl (0.00s)
=== RUN   TestAccStatusCake_basic
--- PASS: TestAccStatusCake_basic (7.48s)
=== RUN   TestAccStatusCake_withUpdate
--- PASS: TestAccStatusCake_withUpdate (10.44s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/statuscake 17.962s

Thanks

Paul

@MrPink MrPink deleted the statuscake-contactgroup branch August 29, 2016 08:38
@MrPink
Copy link
Author

MrPink commented Aug 29, 2016

Many thanks @stack72

@ghost
Copy link

ghost commented Apr 22, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants