provider/aws: Add AWS error message to retry APIGateway acc update on

[radeksimko]

As we know the AWS IAM service is eventually consistent and although we already have the retry logic in place for this resource it seems there is another (new?) error message returned in case the IAM Role has not been propagated yet.

I discovered this when running API Gateway acceptance tests:

=== RUN   TestAccAWSAPIGatewayAccount_basic
--- FAIL: TestAccAWSAPIGatewayAccount_basic (41.95s)
        testing.go:265: Step 1 error: Error applying: 1 error(s) occurred:

            * aws_api_gateway_account.test: Updating API Gateway Account failed: BadRequestException: API Gateway could not successfully write to CloudWatch Logs using the ARN specified. This account may have reached a limit in CloudWatch Logs.
                status code: 400, request id: 3eedb1df-6def-12e6-b761-f503a5eda22b

[stack72]

@radeksimko this LGTM! Test results:

% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSAPIGatewayAccount_'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/08/29 19:57:23 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSAPIGatewayAccount_ -timeout 120m
=== RUN   TestAccAWSAPIGatewayAccount_importBasic
--- PASS: TestAccAWSAPIGatewayAccount_importBasic (16.22s)
=== RUN   TestAccAWSAPIGatewayAccount_basic
--- PASS: TestAccAWSAPIGatewayAccount_basic (109.93s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    126.173s

Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.