Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rds password if provided while creating from snapshot #8622

Merged
merged 1 commit into from
Dec 19, 2016
Merged

Update rds password if provided while creating from snapshot #8622

merged 1 commit into from
Dec 19, 2016

Conversation

sharmaansh21
Copy link
Contributor

Fixes #8604

@sharmaansh21 sharmaansh21 changed the title [W.I.P] Update rds password if provided while creating from snapshot Update rds password if provided while creating from snapshot Sep 2, 2016
@sharmaansh21
Copy link
Contributor Author

/cc @stack72

@stack72
Copy link
Contributor

stack72 commented Sep 2, 2016

Hi @optimisticanshul

Can you please add the output of the acceptance test run here please?

Paul

@stack72 stack72 self-assigned this Sep 2, 2016
@stack72 stack72 added the waiting-response An issue/pull request is waiting for a response from the community label Sep 2, 2016
@stack72
Copy link
Contributor

stack72 commented Sep 7, 2016

ping @optimisticanshul :)

@stack72 stack72 removed their assignment Sep 7, 2016
@sharmaansh21
Copy link
Contributor Author

sharmaansh21 commented Sep 9, 2016 •
edited
Loading

@stack72 I don't think we have test for restoring from snapshot. Shall i write test in this PR or a separate PR.

@mitchellh
Copy link
Contributor

@optimisticanshul This PR would be wonderful. Thank you!

@catsby
Copy link
Contributor

catsby commented Dec 19, 2016

Hey all – I've tested this manually and it worked as expected. I wrote an acceptance test too but am hitting timeout issues. I'm going to go ahead and merge as is.

@catsby catsby merged commit 7998c3b into hashicorp:master Dec 19, 2016
simontabor added a commit to simontabor/terraform-provider-aws that referenced this pull request Sep 26, 2018
@simontabor
Run a cluster update for master_password snapshots
056e11a 
This reproduces the behaviour added in hashicorp/terraform#8622 to ensure that the password is changed if specified when creating a cluster from a snapshot
@ghost
Copy link

ghost commented Apr 18, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement provider/aws waiting-response An issue/pull request is waiting for a response from the community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AWS RDS - Restoring from snapshot doesn't set username & password
4 participants
@sharmaansh21 @stack72 @mitchellh @catsby