provider/aws: Add JSON validation to the aws_elasticsearch_domain resource. #8898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Part of work which began in #8028. |
kwilczynski
changed the title
|
Acceptance test is passing: |
stack72
reviewed
Sep 21, 2016
| @@ -269,7 +270,8 @@ func resourceAwsElasticSearchDomainRead(d *schema.ResourceData, meta interface{} | |||
| ds := out.DomainStatus | |||
|
|
|||
| if ds.AccessPolicies != nil && *ds.AccessPolicies != "" { | |||
| d.Set("access_policies", normalizeJson(*ds.AccessPolicies)) | |||
| policies, _ := normalizeJsonString(*ds.AccessPolicies) | |||
There was a problem hiding this comment.
We need to check for errors here ;)
kwilczynski
force-pushed
the
feature/json-validation-aws_elasticsearch_domain
branch
from
63bc2f2
to
663cd78
Compare
kwilczynski
changed the title
This commit adds support for new helper function which is used to normalise and validate JSON string. Signed-off-by: Krzysztof Wilczynski <[email protected]>
…ument. Signed-off-by: Krzysztof Wilczynski <[email protected]>
kwilczynski
force-pushed
the
feature/json-validation-aws_elasticsearch_domain
branch
from
663cd78
to
dd1d41d
Compare
kwilczynski
changed the title
|
LGTM! Thanks for the work here :) |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for new helper function which is used to
normalise and validate JSON string.
Signed-off-by: Krzysztof Wilczynski [email protected]