provider/aws: Add JSON validation to the aws_sns_topic resource.

[kwilczynski]

This commit adds support for new helper function which is used to
normalise and validate JSON string.

Signed-off-by: Krzysztof Wilczynski [email protected]

[kwilczynski]

Part of work which began in #8028.

[kwilczynski]

Acceptance test is passing:

$ make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSSNSTopic_'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/09/14 17:20:58 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSSNSTopic_ -timeout 120m
=== RUN   TestAccAWSSNSTopic_importBasic
--- PASS: TestAccAWSSNSTopic_importBasic (13.27s)
=== RUN   TestAccAWSSNSTopic_basic
--- PASS: TestAccAWSSNSTopic_basic (13.88s)
=== RUN   TestAccAWSSNSTopic_policy
--- PASS: TestAccAWSSNSTopic_policy (15.33s)
=== RUN   TestAccAWSSNSTopic_withIAMRole
--- PASS: TestAccAWSSNSTopic_withIAMRole (27.96s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    70.456s

[stack72]

I believe we need the error checking here (as discussed in slack)

[kwilczynski]

This could be replaced with way simpler StateFunc, all these other code here is not really needed.

[stack72]

I have just fixed this up locally :) There was an issue with extra imports

builtin/providers/aws/resource_aws_sns_topic.go:4: imported and not used: "bytes"
builtin/providers/aws/resource_aws_sns_topic.go:5: imported and not used: "encoding/json"

% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSSNSTopic_'                                                                           2 ↵
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/09/22 09:05:49 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSSNSTopic_ -timeout 120m
=== RUN   TestAccAWSSNSTopic_importBasic
--- PASS: TestAccAWSSNSTopic_importBasic (18.46s)
=== RUN   TestAccAWSSNSTopic_basic
--- PASS: TestAccAWSSNSTopic_basic (17.98s)
=== RUN   TestAccAWSSNSTopic_policy
--- PASS: TestAccAWSSNSTopic_policy (19.45s)
=== RUN   TestAccAWSSNSTopic_withIAMRole
--- PASS: TestAccAWSSNSTopic_withIAMRole (27.03s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    82.936s

[stack72]

Manually merged :)

[kwilczynski]

@stack72 thank you! I wasn't able to push fast enough from the train :)

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.