provider/azurerm: add servicebus_topic resource

[pmcatominey]

Includes a small bump of SDK version to pull in go-autorest time parsing fix.

TF_ACC=1 go test ./builtin/providers/azurerm -v -run TestAccAzureRMServiceBusTopic -timeout 120m
=== RUN   TestAccAzureRMServiceBusTopic_importBasic
--- PASS: TestAccAzureRMServiceBusTopic_importBasic (328.72s)
=== RUN   TestAccAzureRMServiceBusTopic_basic
--- PASS: TestAccAzureRMServiceBusTopic_basic (331.04s)
=== RUN   TestAccAzureRMServiceBusTopic_update
--- PASS: TestAccAzureRMServiceBusTopic_update (348.69s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/azurerm    1008.588s

[stack72]

Hi @pmcatominey

This LGTM! 1 small nit that isn't a limiting factor - just running the tests now

P.

[stack72]

We shouldn't have to ignore this anymore - if you look at PR #9073 for details on how to handle this :)

[pmcatominey]

Thanks, fixed and noted :)

[stack72]

Is there any eventual consistency here or can we guarantee that this will be immediately available?

[pmcatominey]

Looking at the logs before, the topic appears to be returned in the body of the create request

[pmcatominey]

I've just updated with the resource group name importing changes, recommend you run the tests again to be sure :).

[stack72]

Initial test run:

% make testacc TEST=./builtin/providers/azurerm TESTARGS='-run=TestAccAzureRMServiceBusTopic'                                                                                                             ✭
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/09/30 16:47:25 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/azurerm -v -run=TestAccAzureRMServiceBusTopic -timeout 120m
=== RUN   TestAccAzureRMServiceBusTopic_importBasic
--- PASS: TestAccAzureRMServiceBusTopic_importBasic (334.43s)
=== RUN   TestAccAzureRMServiceBusTopic_basic
--- PASS: TestAccAzureRMServiceBusTopic_basic (334.15s)
=== RUN   TestAccAzureRMServiceBusTopic_update
--- PASS: TestAccAzureRMServiceBusTopic_update (342.30s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/azurerm    1010.893s

Will run the others when I am off this flight :)

[pmcatominey]

Pushed again with the updated azurerm layout.

[stack72]

Hi @pmcatominey

Thanks for the work here - just ran the latest tests and all looks good to me!

% make testacc TEST=./builtin/providers/azurerm TESTARGS='-run=TestAccAzureRMServiceBusTopic'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/10/03 13:40:58 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/azurerm -v -run=TestAccAzureRMServiceBusTopic -timeout 120m
=== RUN   TestAccAzureRMServiceBusTopic_importBasic
--- PASS: TestAccAzureRMServiceBusTopic_importBasic (332.75s)
=== RUN   TestAccAzureRMServiceBusTopic_basic
--- PASS: TestAccAzureRMServiceBusTopic_basic (330.50s)
=== RUN   TestAccAzureRMServiceBusTopic_update
--- PASS: TestAccAzureRMServiceBusTopic_update (348.09s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/azurerm    1011.362s

Paul

[stack72]

@pmcatominey I am going to revert this PR until the timestamp issue is fixed

[pmcatominey]

@stack72 no problem, you'll need to revert subscriptions too.

On Wed, 5 Oct 2016, 00:49 Paul Stack, [email protected] wrote:

@pmcatominey https://github.com/pmcatominey I am going to revert this
PR until the timestamp issue is fixed

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#9151 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA4FSGWBam1MT3tN-73FAdalhQGIzcK2ks5qwuX2gaJpZM4KLIoW
.

[stack72]

No need to revert now as the timestamp issue is fixed by bumping to go-autorest 7.2.1 :)

[pmcatominey]

Awesome!

On Wed, 5 Oct 2016, 08:52 Paul Stack, [email protected] wrote:

No need to revert now as the timestamp issue is fixed by bumping to
go-autorest 7.2.1 :)

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#9151 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA4FSD6vgiVn36ObnerRZeIeyJioTxccks5qw1c7gaJpZM4KLIoW
.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.