Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Import aws_db_event_subscription #9220

Merged
merged 1 commit into from
Oct 5, 2016

Conversation

AMeng
Copy link
Contributor

@AMeng AMeng commented Oct 4, 2016

$ make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSDBEventSubscription_importBasic'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/10/04 14:19:32 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSDBEventSubscription_importBasic -timeout 120m
=== RUN   TestAccAWSDBEventSubscription_importBasic
--- PASS: TestAccAWSDBEventSubscription_importBasic (471.58s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    471.587s

@stack72
Copy link
Contributor

stack72 commented Oct 4, 2016

Hi @AMeng

Left 1 comment - thanks for the work here :) Another great PR!

P.

@stack72 stack72 added the waiting-response An issue/pull request is waiting for a response from the community label Oct 4, 2016
@AMeng
Copy link
Contributor Author

AMeng commented Oct 4, 2016

Comments addressed.

@stack72
Copy link
Contributor

stack72 commented Oct 4, 2016

Thanks!! :)

@stack72
Copy link
Contributor

stack72 commented Oct 5, 2016

Tests look good on this - thanks again :)

% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSDBEventSubscription_'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/10/05 00:06:29 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSDBEventSubscription_ -timeout 120m
=== RUN   TestAccAWSDBEventSubscription_importBasic
--- PASS: TestAccAWSDBEventSubscription_importBasic (886.00s)
=== RUN   TestAccAWSDBEventSubscription_basicUpdate
--- PASS: TestAccAWSDBEventSubscription_basicUpdate (1503.44s)
=== RUN   TestAccAWSDBEventSubscription_withSourceIds
--- PASS: TestAccAWSDBEventSubscription_withSourceIds (1011.28s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    3400.751s

@stack72 stack72 merged commit aa97ebd into hashicorp:master Oct 5, 2016
@ghost
Copy link

ghost commented Apr 21, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement provider/aws waiting-response An issue/pull request is waiting for a response from the community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants