provider/azurerm: add account_kind and access_tier to storage_account #9408
Conversation
pmcatominey
commented
Oct 17, 2016
pmcatominey
commented
… resource TF_ACC=1 go test ./builtin/providers/azurerm -v -run TestAccAzureRMStorageAccount -timeout 120m === RUN TestAccAzureRMStorageAccount_importBasic --- PASS: TestAccAzureRMStorageAccount_importBasic (140.06s) === RUN TestAccAzureRMStorageAccount_basic --- PASS: TestAccAzureRMStorageAccount_basic (155.43s) === RUN TestAccAzureRMStorageAccount_disappears --- PASS: TestAccAzureRMStorageAccount_disappears (134.99s) === RUN TestAccAzureRMStorageAccount_blobEncryption --- PASS: TestAccAzureRMStorageAccount_blobEncryption (161.59s) === RUN TestAccAzureRMStorageAccount_blobStorageWithUpdate --- PASS: TestAccAzureRMStorageAccount_blobStorageWithUpdate (131.49s) PASS ok github.com/hashicorp/terraform/builtin/providers/azurerm 723.694s
| @@ -153,6 +181,17 @@ func resourceArmStorageAccountCreate(d *schema.ResourceData, meta interface{}) e | |||
| }, | |||
| } | |||
|
|
|||
| // AccessTier is only valid for BlobStorage accounts | |||
| if accountKind == string(storage.BlobStorage) { | |||
| accessTier, ok := d.GetOk("access_tier") | |||
There was a problem hiding this comment.
I think we should add the default as part of the scheme declaration rather than defaulting in code
There was a problem hiding this comment.
The issue I faced is that accessTier can only be specified on requests for BlobStorage accounts, using the Default parameter meant it would be set for all types
| d.Set("account_type", resp.Sku.Name) | ||
| d.Set("primary_location", resp.Properties.PrimaryLocation) | ||
| d.Set("secondary_location", resp.Properties.SecondaryLocation) | ||
|
|
||
| if resp.Properties.AccessTier != "" { |
There was a problem hiding this comment.
If access tier is computed: true, is there ever any way this can be nil?
|
Thanks for the responses - LGTM :) |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
