provider/google: add scope aliases #9442
Conversation
| "logging-write": "https://www.googleapis.com/auth/logging.write", | ||
| "monitoring": "https://www.googleapis.com/auth/monitoring", | ||
| "monitoring-write": "https://www.googleapis.com/auth/monitoring.write", | ||
| "pubsub": "https://www.googleapis.com/auth/pubsub", |
There was a problem hiding this comment.
I don't see pubsub in the list you linked. Was it deprecated?
There was a problem hiding this comment.
I've checked pubsub alias with gcloud, it doesn't work:
gcloud compute instances create test-scopes \
--image-project=debian-cloud \
--image-family=debian-8 \
--machine-type n1-standard-1 \
--scopes pubsub
ERROR: (gcloud.compute.instances.create) Some requests did not succeed:
- One or more of the service account scopes are invalid: 'pubsub'
There was a problem hiding this comment.
So I guess we should remove this from the list in Terraform too, while we're updating the scopes?
There was a problem hiding this comment.
Wouldn't it break configurations, that uses this alias?
Because full scope "https://www.googleapis.com/auth/pubsub" works, so alias is workable now in Terraform.
There was a problem hiding this comment.
Ah. Yeah, I just wanted to make sure that it was still a valid scope. Was able to confirm here: https://developers.google.com/identity/protocols/googlescopes#pubsubv1
obsh
force-pushed
the
google-scope-aliases
branch
from
650d4ef
to
f9b6d2d
Compare
|
Also I see "cloud-source-repos-ro" in the list, I'm pretty sure it was added today. |
|
Thanks for the work here @obsh :) LGTM! |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Hi,
this PR adds following gcloud scope aliases:
It is based on scope aliases list from this page: :https://cloud.google.com/sdk/gcloud/reference/compute/instances/create