provider/google Support MySQL 5.7 instances #9673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @wendorf Thanks for the change here - please can you rebase your PR - I just merged your other and it has caused conflicts thanks Paul |
stack72
added
enhancement
waiting-response
Google Cloud SQL has first-gen and second-gen instances with different supported versions of MySQL.
Creating SQL instances for MySQL 5.7 can take over 7 minutes, so the timeout needs to be increased to allow the google_sql_database_instance resource to successfully create.
wendorf
force-pushed
the
support_google_mysql_5_7
branch
from
b07e78f
to
b749d31
Compare
|
Rebased. Thanks for addressing these so quickly! |
|
LGTM! Thanks :) |
mathieuherbert
pushed a commit
to mathieuherbert/terraform
that referenced
this pull request
Oct 30, 2016
* provider/google Document MySQL versions for second generation instances Google Cloud SQL has first-gen and second-gen instances with different supported versions of MySQL. * provider/google Increase SQL Admin operation timeout to 10 minutes Creating SQL instances for MySQL 5.7 can take over 7 minutes, so the timeout needs to be increased to allow the google_sql_database_instance resource to successfully create.
gusmat
pushed a commit
to gusmat/terraform
that referenced
this pull request
Dec 6, 2016
* provider/google Document MySQL versions for second generation instances Google Cloud SQL has first-gen and second-gen instances with different supported versions of MySQL. * provider/google Increase SQL Admin operation timeout to 10 minutes Creating SQL instances for MySQL 5.7 can take over 7 minutes, so the timeout needs to be increased to allow the google_sql_database_instance resource to successfully create.
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Google Cloud SQL has support for MySQL 5.7, but the option is not documented in the
google_sql_database_instanceresource, and the resource times out when attempting to create. These commits document creating 5.7 and allow it to succeed.