provider/scaleway server volume property

[nicolai86]

as discussed in #9254 and #9499, some Scaleway server instance types require volumes to be specified at creation time, in order to be used.

The Scaleway CLI chooses to hide this from the user, but I think it's worthwile to make this choice explicit.

this PR adds a new property to scaleway_server, to make this work:

resource "scaleway_server" "test" {
  name = "test"
  image = "5faef9cd-ea9b-4a63-9171-9e26bec03dbc"
  type = "VC1M"

  volume {
    size_in_gb = 50
    type = "l_ssd"
  }
}

I've updated the docs and added test cases which pass:

TF_ACC=1 go test ./builtin/providers/scaleway -v -run=TestAccScalewayServer_Volumes -timeout 120m
=== RUN   TestAccScalewayServer_Volumes
--- PASS: TestAccScalewayServer_Volumes (98.30s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/scaleway   98.317s
kepler22b@terraform [scaleway/server-private-volumes*] # tig

this PR might need rebasing once #9687 is merged.

[stack72]

Hi @nicolai86

So close on this one! one of the tests fails:

=== RUN   TestAccScalewayVolume_importBasic
--- FAIL: TestAccScalewayVolume_importBasic (4.41s)
    testing.go:265: Step 1 error: ImportStateVerify attributes not equivalent. Difference is shown below. Top is actual, bottom is expected.

        (map[string]string) {
        }


        (map[string]string) (len=1) {
         (string) (len=10) "size_in_gb": (string) (len=1) "2"
        }

P.

[nicolai86]

Hey @stack72

turns out it's an issue introduced in #9687. I should get into the habit of always running ALL the tests.

Fixed with a0e7825 , caa3ecc and a970396.

[nicolai86]

Now all the tests are green:

TF_ACC=1 go test ./builtin/providers/scaleway -v -run=TestAccScaleway -timeout 120m
=== RUN   TestAccScalewayDataSourceBootscript_Basic
--- PASS: TestAccScalewayDataSourceBootscript_Basic (1.53s)
=== RUN   TestAccScalewayDataSourceBootscript_Filtered
--- PASS: TestAccScalewayDataSourceBootscript_Filtered (1.63s)
=== RUN   TestAccScalewayDataSourceImage_Basic
--- PASS: TestAccScalewayDataSourceImage_Basic (8.22s)
=== RUN   TestAccScalewayDataSourceImage_Filtered
--- PASS: TestAccScalewayDataSourceImage_Filtered (8.24s)
=== RUN   TestAccScalewayIP_importBasic
--- PASS: TestAccScalewayIP_importBasic (2.16s)
=== RUN   TestAccScalewaySecurityGroup_importBasic
--- PASS: TestAccScalewaySecurityGroup_importBasic (2.23s)
=== RUN   TestAccScalewayServer_importBasic
--- PASS: TestAccScalewayServer_importBasic (106.45s)
=== RUN   TestAccScalewayVolume_importBasic
--- PASS: TestAccScalewayVolume_importBasic (2.97s)
=== RUN   TestAccScalewayIP_Basic
--- PASS: TestAccScalewayIP_Basic (13.27s)
=== RUN   TestAccScalewaySecurityGroupRule_Basic
--- PASS: TestAccScalewaySecurityGroupRule_Basic (10.55s)
=== RUN   TestAccScalewaySecurityGroup_Basic
--- PASS: TestAccScalewaySecurityGroup_Basic (2.49s)
=== RUN   TestAccScalewayServer_Basic
--- PASS: TestAccScalewayServer_Basic (105.04s)
=== RUN   TestAccScalewayServer_Volumes
--- PASS: TestAccScalewayServer_Volumes (141.97s)
=== RUN   TestAccScalewayServer_SecurityGroup
--- PASS: TestAccScalewayServer_SecurityGroup (90.29s)
=== RUN   TestAccScalewayVolumeAttachment_Basic
--- PASS: TestAccScalewayVolumeAttachment_Basic (331.85s)
=== RUN   TestAccScalewayVolume_Basic
--- PASS: TestAccScalewayVolume_Basic (3.57s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/scaleway   832.462s

[stack72]

You rock! Thanks so much :)

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.