provider/aws: removing toLower from flattenElastiCacheParameters

[jmasseo]

aws_elasticache_parameter_group parameters can be case sensitive
Namely notify-keyspace-events.
There are a few other instances in structure.go where parameter values are toLower'd. I'm not certain this causes any issues. I only found one other person making reference to this problem at the very bottom of issue 5854.
#5854

[stack72]

Hi @jmasseo

Thanks for the work here - I agree that this shouldn't have been in place and that we should remove it

tests look good:

% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSDBParameterGroup_'                                                    1 ↵
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/11/09 10:14:16 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSDBParameterGroup_ -timeout 120m
=== RUN   TestAccAWSDBParameterGroup_importBasic
--- PASS: TestAccAWSDBParameterGroup_importBasic (28.12s)
=== RUN   TestAccAWSDBParameterGroup_limit
--- PASS: TestAccAWSDBParameterGroup_limit (47.48s)
=== RUN   TestAccAWSDBParameterGroup_basic
--- PASS: TestAccAWSDBParameterGroup_basic (43.48s)
=== RUN   TestAccAWSDBParameterGroup_withApplyMethod
--- PASS: TestAccAWSDBParameterGroup_withApplyMethod (26.65s)
=== RUN   TestAccAWSDBParameterGroup_Only
--- PASS: TestAccAWSDBParameterGroup_Only (22.64s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    168.395s

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.