provider/aws: Fix hashing of EBS volumes in spot fleet requests to prevent panics #9857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spot fleet requests can have EBS volumes attached to them, and at the moment we're getting reports that crashes can be experienced with them. This adds an acceptance test that exercises creating a Spot Fleet request that has a non-instance EBS volume attached. This successfully reproduces the panic.
When computing the set key for an EBS block device, we were using the wrong function; we had hashEphemeralBlockDevice instead of hashEbsBlockDevice. This caused a panic by trying to access the virtual_name attribute that will never be set for EBS block devices. To fix this, I switched to the hashEbsBlockDevice function, which is already being used to compute a Set key in the Schema. But in the default case, where the snapshot_id attribute isn't specified, this also caused a panic. I updated the way the string to hash is generated to check for the existence of the device_name and snapshot_id attributes before we use them, to avoid panics when these optional attributes aren't set.
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spot fleet requests were mistakenly trying to hash EBS volumes using ephemeral volume attributes. This led to crashes and weird EOF errors, as seen in #8822 when the value ended up being nil when it wasn't expected to be.
To fix this, I switched to using the
hashEbsBlockDevicefunction used in the Schema, but that also assumed that optional attributes would be present. To fix the crashes it had, I checked for existence of those attributes before trying to use them.The majority of the PR is an acceptance test that exposed the issue, which now passes.
Fixes #8822