Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/azurerm: EventHubs #9889

Merged
merged 9 commits into from
Nov 7, 2016

Conversation

tombuildsstuff
Copy link
Contributor

@tombuildsstuff tombuildsstuff commented Nov 4, 2016

For context: EventHub's are housed within EventHub Namespaces (#9297).

  • Create/Update
  • Delete
  • Added Standard and Premium SKU tests for EventHub Namespaces
  • Website Documentation
  • Run the Tests

I'll send a follow up PR for this for:

@tombuildsstuff
Copy link
Contributor Author

$ TF_ACC=1 go test ./builtin/providers/azurerm -v -run TestAccAzureRMEventHub -timeout 120m
=== RUN   TestAccAzureRMEventHubNamespace_importBasic
--- PASS: TestAccAzureRMEventHubNamespace_importBasic (362.02s)
=== RUN   TestAccAzureRMEventHub_importBasic
--- PASS: TestAccAzureRMEventHub_importBasic (372.39s)
=== RUN   TestAccAzureRMEventHubNamespaceCapacity_validation
--- PASS: TestAccAzureRMEventHubNamespaceCapacity_validation (0.00s)
=== RUN   TestAccAzureRMEventHubNamespaceSku_validation
--- PASS: TestAccAzureRMEventHubNamespaceSku_validation (0.00s)
=== RUN   TestAccAzureRMEventHubNamespace_basic
--- PASS: TestAccAzureRMEventHubNamespace_basic (356.68s)
=== RUN   TestAccAzureRMEventHubNamespace_standard
--- PASS: TestAccAzureRMEventHubNamespace_standard (365.55s)
=== RUN   TestAccAzureRMEventHubNamespace_readDefaultKeys
--- PASS: TestAccAzureRMEventHubNamespace_readDefaultKeys (355.48s)
=== RUN   TestAccAzureRMEventHubPartitionCount_validation
--- PASS: TestAccAzureRMEventHubPartitionCount_validation (0.00s)
=== RUN   TestAccAzureRMEventHubMessageRetentionCount_validation
--- PASS: TestAccAzureRMEventHubMessageRetentionCount_validation (0.00s)
=== RUN   TestAccAzureRMEventHub_basic
--- PASS: TestAccAzureRMEventHub_basic (365.69s)
=== RUN   TestAccAzureRMEventHub_standard
--- PASS: TestAccAzureRMEventHub_standard (364.90s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/azurerm    2542.737s

@tombuildsstuff tombuildsstuff changed the title [WIP] provider/azurerm: EventHubs provider/azurerm: EventHubs Nov 5, 2016
@stack72
Copy link
Contributor

stack72 commented Nov 7, 2016

Really good PR :) Thanks for all the work here! All tests pass as expected

% make testacc TEST=./builtin/providers/azurerm TESTARGS='-run=TestAccAzureRMEventHub'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/11/07 09:36:05 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/azurerm -v -run=TestAccAzureRMEventHub -timeout 120m
=== RUN   TestAccAzureRMEventHubNamespace_importBasic
--- PASS: TestAccAzureRMEventHubNamespace_importBasic (351.72s)
=== RUN   TestAccAzureRMEventHub_importBasic
--- PASS: TestAccAzureRMEventHub_importBasic (364.61s)
=== RUN   TestAccAzureRMEventHubNamespaceCapacity_validation
--- PASS: TestAccAzureRMEventHubNamespaceCapacity_validation (0.00s)
=== RUN   TestAccAzureRMEventHubNamespaceSku_validation
--- PASS: TestAccAzureRMEventHubNamespaceSku_validation (0.00s)
=== RUN   TestAccAzureRMEventHubNamespace_basic
--- PASS: TestAccAzureRMEventHubNamespace_basic (349.24s)
=== RUN   TestAccAzureRMEventHubNamespace_standard
--- PASS: TestAccAzureRMEventHubNamespace_standard (347.19s)
=== RUN   TestAccAzureRMEventHubNamespace_readDefaultKeys
--- PASS: TestAccAzureRMEventHubNamespace_readDefaultKeys (345.08s)
=== RUN   TestAccAzureRMEventHubPartitionCount_validation
--- PASS: TestAccAzureRMEventHubPartitionCount_validation (0.00s)
=== RUN   TestAccAzureRMEventHubMessageRetentionCount_validation
--- PASS: TestAccAzureRMEventHubMessageRetentionCount_validation (0.00s)
=== RUN   TestAccAzureRMEventHub_basic
--- PASS: TestAccAzureRMEventHub_basic (368.20s)
=== RUN   TestAccAzureRMEventHub_standard
--- PASS: TestAccAzureRMEventHub_standard (364.36s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/azurerm    2490.414s

@stack72 stack72 merged commit b15b7e1 into hashicorp:master Nov 7, 2016
gusmat pushed a commit to gusmat/terraform that referenced this pull request Dec 6, 2016
* Implemented EventHubs

* Missing the sidebar link

* Fixing the type

* Fixing the docs for Namespace

* Removing premium tests

* Checking the correct status code on delete

* Added a test case for the import

* Documentation for importing

* Fixing a typo
@ghost
Copy link

ghost commented Apr 20, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants